Skip to content

Commit 4f6ce93

Browse files
author
Josh DeGraw
committed
Removed MarkNLogNamespaceAsExternal and applied default in SentryOptions
Based on Serilog's doing so as well.
1 parent b45db0e commit 4f6ce93

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

src/Sentry.NLog/SentryNLogOptions.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ namespace Sentry.NLog
1717
[NLogConfigurationItem]
1818
public class SentryNLogOptions : SentryOptions
1919
{
20-
/// <summary>
21-
/// If set to <see langword="true" />, marks namespaces beginning with NLog as external code. Defaults
22-
/// to <see langword="true" />.
23-
/// </summary>
24-
public bool MarkNLogNamespaceAsExternal { get; set; } = true;
2520

2621
/// <summary>
2722
/// How many seconds to wait after triggering Logmanager.Shutdown() before just shutting down the

src/Sentry.NLog/SentryTarget.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,6 @@ protected override void InitializeTarget()
108108

109109
IncludeEventProperties = Options.SendEventPropertiesAsData;
110110

111-
if (Options.MarkNLogNamespaceAsExternal)
112-
{
113-
Options.AddInAppExclude("NLog");
114-
}
115-
116111
// If the sdk is not there, set it on up.
117112
if (Options.InitializeSdk && _sdkDisposable == null)
118113
{

src/Sentry/SentryOptions.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,8 @@ public SentryOptions()
369369
"Newtonsoft.Json",
370370
"FSharp.",
371371
"Serilog",
372-
"Giraffe.");
372+
"Giraffe.",
373+
"NLog");
373374

374375
InAppInclude = ImmutableList<string>.Empty;
375376
}

0 commit comments

Comments
 (0)