Fixed length of scrubbed DebugImage.CodeId in Verify outputs (#3468)

jamescrosswell · web-flow · commit 57101360200d · 2024-07-09T16:19:15.000+02:00
diff --git a/test/Sentry.NLog.Tests/IntegrationTests.Simple.DotNet6_0.verified.txt b/test/Sentry.NLog.Tests/IntegrationTests.Simple.DotNet6_0.verified.txt
@@ -71,7 +71,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.NLog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.NLog.Tests.dll
               }
             ],
diff --git a/test/Sentry.NLog.Tests/IntegrationTests.Simple.DotNet7_0.verified.txt b/test/Sentry.NLog.Tests/IntegrationTests.Simple.DotNet7_0.verified.txt
@@ -71,7 +71,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.NLog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.NLog.Tests.dll
               }
             ],
diff --git a/test/Sentry.NLog.Tests/IntegrationTests.Simple.DotNet8_0.verified.txt b/test/Sentry.NLog.Tests/IntegrationTests.Simple.DotNet8_0.verified.txt
@@ -71,7 +71,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.NLog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.NLog.Tests.dll
               }
             ],
diff --git a/test/Sentry.NLog.Tests/IntegrationTests.Simple.Mono4_0.verified.txt b/test/Sentry.NLog.Tests/IntegrationTests.Simple.Mono4_0.verified.txt
@@ -71,7 +71,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.NLog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.NLog.Tests.dll
               }
             ],
diff --git a/test/Sentry.Serilog.Tests/IntegrationTests.Simple.DotNet6_0.verified.txt b/test/Sentry.Serilog.Tests/IntegrationTests.Simple.DotNet6_0.verified.txt
@@ -237,7 +237,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.Serilog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.Serilog.Tests.dll
               }
             ],
diff --git a/test/Sentry.Serilog.Tests/IntegrationTests.Simple.DotNet7_0.verified.txt b/test/Sentry.Serilog.Tests/IntegrationTests.Simple.DotNet7_0.verified.txt
@@ -237,7 +237,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.Serilog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.Serilog.Tests.dll
               }
             ],
diff --git a/test/Sentry.Serilog.Tests/IntegrationTests.Simple.DotNet8_0.verified.txt b/test/Sentry.Serilog.Tests/IntegrationTests.Simple.DotNet8_0.verified.txt
@@ -237,7 +237,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.Serilog.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.Serilog.Tests.dll
               }
             ],
diff --git a/test/Sentry.Testing/VerifyExtensions.cs b/test/Sentry.Testing/VerifyExtensions.cs
@@ -92,7 +92,7 @@ public override void Write(VerifyJsonWriter writer, DebugImage obj)
             obj.DebugChecksum = ScrubAlphaNum(obj.DebugChecksum);
             obj.DebugFile = ScrubPath(obj.DebugFile);
             obj.CodeFile = ScrubPath(obj.CodeFile);
-            obj.CodeId = ScrubAlphaNum(obj.CodeId);
+            obj.CodeId = obj.CodeId is null ? "null" : "______________";
             writer.Serialize(JToken.FromObject(obj));
         }
     }
diff --git a/test/Sentry.Tests/HubTests.CaptureEvent_ActiveTransaction_UnhandledExceptionTransactionEndedAsCrashed.DotNet6_0.verified.txt b/test/Sentry.Tests/HubTests.CaptureEvent_ActiveTransaction_UnhandledExceptionTransactionEndedAsCrashed.DotNet6_0.verified.txt
@@ -79,7 +79,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.Tests.dll
               },
               {
@@ -89,7 +89,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: xunit.execution.dotnet.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../xunit.execution.dotnet.dll
               },
               {
@@ -99,7 +99,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: xunit.core.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../xunit.core.dll
               }
             ],
diff --git a/test/Sentry.Tests/HubTests.CaptureEvent_ActiveTransaction_UnhandledExceptionTransactionEndedAsCrashed.DotNet7_0.verified.txt b/test/Sentry.Tests/HubTests.CaptureEvent_ActiveTransaction_UnhandledExceptionTransactionEndedAsCrashed.DotNet7_0.verified.txt
@@ -79,7 +79,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.Tests.dll
               },
               {
@@ -89,7 +89,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: xunit.execution.dotnet.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../xunit.execution.dotnet.dll
               },
               {
@@ -99,7 +99,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: xunit.core.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../xunit.core.dll
               }
             ],
diff --git a/test/Sentry.Tests/HubTests.CaptureEvent_ActiveTransaction_UnhandledExceptionTransactionEndedAsCrashed.DotNet8_0.verified.txt b/test/Sentry.Tests/HubTests.CaptureEvent_ActiveTransaction_UnhandledExceptionTransactionEndedAsCrashed.DotNet8_0.verified.txt
@@ -79,7 +79,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: .../Sentry.Tests.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../Sentry.Tests.dll
               },
               {
@@ -89,7 +89,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: xunit.execution.dotnet.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../xunit.execution.dotnet.dll
               },
               {
@@ -99,7 +99,7 @@
                 DebugId: ________-____-____-____-____________-________,
                 DebugChecksum: ______:________________________________________________________________,
                 DebugFile: xunit.core.pdb,
-                CodeId: _____________,
+                CodeId: ______________,
                 CodeFile: .../xunit.core.dll
               }
             ],

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@`
`71`	`71`	`DebugId: ________-____-____-____-____________-________,`
`72`	`72`	`DebugChecksum: ______:________________________________________________________________,`
`73`	`73`	`DebugFile: .../Sentry.NLog.Tests.pdb,`
`74`		`- CodeId: _____________,`
	`74`	`+ CodeId: ______________,`
`75`	`75`	`CodeFile: .../Sentry.NLog.Tests.dll`
`76`	`76`	`}`
`77`	`77`	`],`
Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@`
`237`	`237`	`DebugId: ________-____-____-____-____________-________,`
`238`	`238`	`DebugChecksum: ______:________________________________________________________________,`
`239`	`239`	`DebugFile: .../Sentry.Serilog.Tests.pdb,`
`240`		`- CodeId: _____________,`
	`240`	`+ CodeId: ______________,`
`241`	`241`	`CodeFile: .../Sentry.Serilog.Tests.dll`
`242`	`242`	`}`
`243`	`243`	`],`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public override void Write(VerifyJsonWriter writer, DebugImage obj)`
`92`	`92`	`obj.DebugChecksum = ScrubAlphaNum(obj.DebugChecksum);`
`93`	`93`	`obj.DebugFile = ScrubPath(obj.DebugFile);`
`94`	`94`	`obj.CodeFile = ScrubPath(obj.CodeFile);`
`95`		`- obj.CodeId = ScrubAlphaNum(obj.CodeId);`
	`95`	`+ obj.CodeId = obj.CodeId is null ? "null" : "______________";`
`96`	`96`	`writer.Serialize(JToken.FromObject(obj));`
`97`	`97`	`}`
`98`	`98`	`}`