Skip to content

Commit 5d20a0c

Browse files
Updated BindableSentryAspNetCoreOptions to pass tests
1 parent 5ba1121 commit 5d20a0c

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/Sentry.AspNetCore/BindableSentryAspNetCoreOptions.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ internal class BindableSentryAspNetCoreOptions : BindableSentryLoggingOptions
1919
public bool? FlushOnCompletedRequest { get; set; }
2020
public bool? FlushBeforeRequestCompleted { get; set; }
2121
public bool? AdjustStandardEnvironmentNameCasing { get; set; }
22+
public bool? AutoRegisterTracing { get; set; }
2223

2324
public void ApplyTo(SentryAspNetCoreOptions options)
2425
{
@@ -28,5 +29,6 @@ public void ApplyTo(SentryAspNetCoreOptions options)
2829
options.FlushOnCompletedRequest = FlushOnCompletedRequest ?? options.FlushOnCompletedRequest;
2930
options.FlushBeforeRequestCompleted = FlushBeforeRequestCompleted ?? options.FlushBeforeRequestCompleted;
3031
options.AdjustStandardEnvironmentNameCasing = AdjustStandardEnvironmentNameCasing ?? options.AdjustStandardEnvironmentNameCasing;
32+
options.AutoRegisterTracing = AutoRegisterTracing ?? options.AutoRegisterTracing;
3133
}
3234
}

test/Sentry.AspNetCore.Tests/SentryTracingBuilderTests.cs

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ public void UseRouting_AutoRegisterTracingDisabled_SentryTracingNotRegistered()
4545
// Arrange
4646
_fixture.ConfigureServices = services => services.AddRouting();
4747
_fixture.Configure = applicationBuilder => applicationBuilder.UseRouting();
48-
_fixture.ConfigureOptions = options => options.AutoRegisterTracing = false;
48+
_fixture.ConfigureOptions = options =>
49+
{
50+
options.Dsn = Sentry.Constants.DisableSdkDsnValue;
51+
options.AutoRegisterTracing = false;
52+
};
4953

5054
// Act - implicit
5155
var (_, builder) = _fixture.GetSut();
@@ -60,7 +64,11 @@ public void UseRouting_OtelInstrumentation_SentryTracingNotRegistered()
6064
// Arrange
6165
_fixture.ConfigureServices = services => services.AddRouting();
6266
_fixture.Configure = applicationBuilder => applicationBuilder.UseRouting();
63-
_fixture.ConfigureOptions = options => options.Instrumenter = Instrumenter.OpenTelemetry;
67+
_fixture.ConfigureOptions = options =>
68+
{
69+
options.Dsn = Sentry.Constants.DisableSdkDsnValue;
70+
options.Instrumenter = Instrumenter.OpenTelemetry;
71+
};
6472

6573
// Act - implicit
6674
var (_, builder) = _fixture.GetSut();
@@ -82,6 +90,10 @@ public void UseRouting_SentryTracingRegisteredWithoutWarning()
8290
services.AddRouting();
8391
};
8492
_fixture.Configure = applicationBuilder => applicationBuilder.UseRouting();
93+
_fixture.ConfigureOptions = options =>
94+
{
95+
options.Dsn = Sentry.Constants.DisableSdkDsnValue;
96+
};
8597

8698
// Act
8799
var (_, builder) = _fixture.GetSut();
@@ -107,6 +119,10 @@ public void UseSentryTracing_AutoRegisterTracing_Warning()
107119
applicationBuilder.UseRouting();
108120
applicationBuilder.UseSentryTracing();
109121
};
122+
_fixture.ConfigureOptions = options =>
123+
{
124+
options.Dsn = Sentry.Constants.DisableSdkDsnValue;
125+
};
110126

111127
// Act
112128
var _ = _fixture.GetSut();

0 commit comments

Comments
 (0)