Skip to content

Commit 815d9fb

Browse files
jpnurmiclaude
andauthored
ci: run iOS device tests on arm64 (#4961)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1753b23 commit 815d9fb

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

.github/workflows/device-tests-ios.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ jobs:
7878
id: first-test-run
7979
continue-on-error: true
8080
timeout-minutes: 40
81-
run: pwsh scripts/device-test.ps1 ios -Run
81+
run: pwsh scripts/device-test.ps1 ios -Run -Verbose
8282

8383
- name: Retry Tests (if previous failed to run)
8484
if: steps.first-test-run.outcome == 'failure'
8585
timeout-minutes: 40
86-
run: pwsh scripts/device-test.ps1 ios -Run
86+
run: pwsh scripts/device-test.ps1 ios -Run -Verbose
8787

8888
- name: Run Integration Tests
8989
id: first-integration-test-run

scripts/device-test-utils.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ function Install-XHarness
44
{
55
$CI = Test-Path env:CI
66
Push-Location ($CI ? $env:RUNNER_TEMP : $IsWindows ? $env:TMP : $IsMacos ? $env:TMPDIR : '/tmp')
7-
dotnet tool install Microsoft.DotNet.XHarness.CLI --global --version '10.0.0-prerelease.25466.1' `
7+
dotnet tool install Microsoft.DotNet.XHarness.CLI --global --version '11.0.0-prerelease.26117.1' `
88
--add-source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json
99
Pop-Location
1010
}

scripts/device-test.ps1

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ try
5252
{
5353
$Tfm += '-ios'
5454
$group = 'apple'
55-
# Always use x64 on iOS, since arm64 doesn't support JIT, which is required for tests using NSubstitute
56-
$arch = 'x64'
5755
$buildDir = "test/Sentry.Maui.Device.TestApp/bin/Release/$Tfm/iossimulator-$arch"
5856
$envValue = $CI ? 'true' : 'false'
5957
$arguments = @(

test/Sentry.Extensions.Logging.Tests/SentryHttpMessageHandlerBuilderFilterTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ public class SentryHttpMessageHandlerBuilderFilterTests
77
[SkippableFact]
88
public void Configure_HandlerEnabled_ShouldAddSentryHttpMessageHandler()
99
{
10-
#if __ANDROID__
11-
Skip.If(true, "Can't create proxies for classes without parameterless constructors on Android");
10+
#if __MOBILE__
11+
Skip.If(true, "Can't create proxies for classes without parameterless constructors on mobile");
1212
#endif
1313

1414
// Arrange
@@ -31,8 +31,8 @@ public void Configure_HandlerEnabled_ShouldAddSentryHttpMessageHandler()
3131
[SkippableFact]
3232
public void Configure_HandlerDisabled_ShouldNotAddSentryHttpMessageHandler()
3333
{
34-
#if __ANDROID__
35-
Skip.If(true, "Can't create proxies for classes without parameterless constructors on Android");
34+
#if __MOBILE__
35+
Skip.If(true, "Can't create proxies for classes without parameterless constructors on mobile");
3636
#endif
3737

3838
// Arrange

test/Sentry.Maui.Device.TestApp/Sentry.Maui.Device.TestApp.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@
6565
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'android' And '$(OSArchitecture)' == 'Arm64'">android-arm64</RuntimeIdentifier>
6666
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'android' And '$(OSArchitecture)' == 'x64'">android-x64</RuntimeIdentifier>
6767

68-
<!-- On iOS we always target x64 since Arm64 doesn't support JIT, which is required by tests using NSubstitute -->
69-
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'ios'">iossimulator-x64</RuntimeIdentifier>
68+
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'ios' And '$(OSArchitecture)' == 'Arm64'">iossimulator-arm64</RuntimeIdentifier>
69+
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'ios' And '$(OSArchitecture)' == 'x64'">iossimulator-x64</RuntimeIdentifier>
7070

7171
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'maccatalyst' And '$(OSArchitecture)' == 'Arm64'">maccatalyst-arm64</RuntimeIdentifier>
7272
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'maccatalyst' And '$(OSArchitecture)' == 'x64'">maccatalyst-x64</RuntimeIdentifier>

0 commit comments

Comments
 (0)