Passing tests

Author: aritchie

src/Sentry.Maui.CommunityToolkit.Mvvm/CtMvvmMauiElementEventBinder.cs

@@ -130,6 +130,8 @@ private void RelayCommandOnPropertyChanged(object? sender, PropertyChangedEventA
             if (relay.IsRunning)
             {
                 var transaction = hub.StartTransaction("ctmvvm", "relay.command");
+                hub.ConfigureScope(x => x.Transaction ??= transaction);
+
                 _contexts.TryAdd(relay, transaction);
             }
             else if (_contexts.TryGetValue(relay, out var value))

test/Sentry.Maui.Tests/MauiEventsBinderTests.CtMvvmAsyncRelayCommands.cs

@@ -1,27 +1,32 @@
 using CommunityToolkit.Mvvm.ComponentModel;
 using CommunityToolkit.Mvvm.Input;
-using Sentry.Maui.Internal;
-using Sentry.Maui.Tests.Mocks;
+using Sentry.Maui.CommunityToolkitMvvm;
 
 namespace Sentry.Maui.Tests;
 
 public partial class MauiEventsBinderTests
 {
     [Fact]
-    public async Task AsyncRelayCommand_AddsSpan()
+    public async Task AsyncRelayCommand_AddsTransaction()
     {
         var vm = new TestCtMvvmViewModel();
-        button.Command = vm.TestCommand;
-
-        _fixture.Binder.OnApplicationOnDescendantAdded(null, new ElementEventArgs(button));
+        var button = new Button
+        {
+            Command = vm.TestCommand
+        };
+        //_fixture.Binder.OnApplicationOnDescendantAdded(null, new ElementEventArgs(button));
+        var binder = new CtMvvmMauiElementEventBinder(_fixture.Hub);
+        binder.Bind(button, _ => {});
 
         button.Command.Execute(null!);
 
         // we need to wait for async command to run
         await Task.Delay(TimeSpan.FromSeconds(1.1));
 
         // Assert
-        _fixture.Scope.Span.Should().NotBeNull();
+        _fixture.Scope.Transaction.Should().NotBeNull("Transaction should be created");
+        _fixture.Scope.Transaction!.Name.Should().Be("ctmvvm");
+        _fixture.Scope.Transaction!.Status.Should().Be(SpanStatus.Ok, "Transaction should be ok");
     }
 }
 

test/Sentry.Maui.Tests/MauiEventsBinderTests.cs

@@ -7,6 +7,8 @@ public partial class MauiEventsBinderTests
 {
     private class Fixture
     {
+        public IHub Hub { get; }
+
         public MauiEventsBinder Binder { get; }
 
         public Scope Scope { get; } = new();
@@ -15,8 +17,8 @@ private class Fixture
 
         public Fixture()
         {
-            var hub = Substitute.For<IHub>();
-            hub.When(h => h.ConfigureScope(Arg.Any<Action<Scope>>()))
+            Hub = Substitute.For<IHub>();
+            Hub.When(h => h.ConfigureScope(Arg.Any<Action<Scope>>()))
                 .Do(c => c.Arg<Action<Scope>>()(Scope));
 
             Options.Debug = true;
@@ -25,12 +27,12 @@ public Fixture()
             Options.DiagnosticLogger = logger;
             var options = Microsoft.Extensions.Options.Options.Create(Options);
             Binder = new MauiEventsBinder(
-                hub,
+                Hub,
                 options,
                 [
                     new MauiButtonEventsBinder(),
                     new MauiImageButtonEventsBinder(),
-                    new CtMvvmMauiElementEventBinder(hub)
+                    new CtMvvmMauiElementEventBinder(Hub)
                 ]
             );
         }