fix: Read size on each request

Author: bruno-garcia

src/Sentry.AspNetCore/ScopeExtensions.cs

@@ -104,7 +104,7 @@ private static void SetBody(BaseScope scope, HttpContext context, SentryAspNetCo
             {
                 return;
             }
-            var dispatcher = new RequestBodyExtractionDispatcher(extractors, options, options.MaxRequestBodySize);
+            var dispatcher = new RequestBodyExtractionDispatcher(extractors, options, () => options.MaxRequestBodySize);
 
             var body = dispatcher.ExtractPayload(new HttpRequestAdapter(context.Request));
             if (body != null)

src/Sentry/Extensibility/RequestBodyExtractionDispatcher.cs

@@ -6,15 +6,15 @@ namespace Sentry.Extensibility
     public class RequestBodyExtractionDispatcher : IRequestPayloadExtractor
     {
         private readonly SentryOptions _options;
-        private readonly RequestSize _size;
+        private readonly Func<RequestSize> _sizeSwitch;
 
         internal IEnumerable<IRequestPayloadExtractor> Extractors { get; }
 
-        public RequestBodyExtractionDispatcher(IEnumerable<IRequestPayloadExtractor> extractors, SentryOptions options, RequestSize size)
+        public RequestBodyExtractionDispatcher(IEnumerable<IRequestPayloadExtractor> extractors, SentryOptions options, Func<RequestSize> sizeSwitch)
         {
             Extractors = extractors ?? throw new ArgumentNullException(nameof(extractors));
             _options = options ?? throw new ArgumentNullException(nameof(options));
-            _size = size;
+            _sizeSwitch = sizeSwitch ?? throw new ArgumentNullException(nameof(sizeSwitch));
         }
 
         public object ExtractPayload(IHttpRequest request)
@@ -24,13 +24,15 @@ public object ExtractPayload(IHttpRequest request)
                 return null;
             }
 
-            switch (_size)
+            var size = _sizeSwitch();
+
+            switch (size)
             {
                 case RequestSize.Small when request.ContentLength < 1_000:
                 case RequestSize.Medium when request.ContentLength < 10_000:
                 case RequestSize.Always:
                     _options.DiagnosticLogger.LogDebug("Attempting to read request body of size: {0}, configured max: {1}.",
-                        request.ContentLength, _size);
+                        request.ContentLength, size);
 
                     foreach (var extractor in Extractors)
                     {
@@ -52,7 +54,7 @@ public object ExtractPayload(IHttpRequest request)
                     break;
                 default:
                     _options.DiagnosticLogger.LogWarning("Ignoring request with Size {0} and configuration RequestSize {1}",
-                        request.ContentLength, _size);
+                        request.ContentLength, size);
                     break;
             }
 

src/Sentry/SentryOptions.cs

@@ -349,7 +349,7 @@ public SentryOptions()
                                 new DefaultRequestPayloadExtractor()
                         },
                         this,
-                        MaxRequestBodySize)));
+                        () => MaxRequestBodySize)));
 #endif
             ExceptionProcessors
                 = ImmutableList.Create<ISentryEventExceptionProcessor>(

test/Sentry.Tests/Extensibility/RequestBodyExtractionDispatcherTests.cs

@@ -24,7 +24,7 @@ public Fixture()
                 Extractors = new[] { Extractor };
             }
 
-            public RequestBodyExtractionDispatcher GetSut() => new RequestBodyExtractionDispatcher(Extractors, SentryOptions, RequestSize);
+            public RequestBodyExtractionDispatcher GetSut() => new RequestBodyExtractionDispatcher(Extractors, SentryOptions, () => RequestSize);
         }
 
         private readonly Fixture _fixture = new Fixture();