Merge branch 'master' of github.com:getsentry/sentry-dotnet into feature/aspnetcore-configure-scope

Author: bruno-garcia

Directory.Build.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <Version>1.1.2-beta</Version>
+    <Version>1.1.2</Version>
 
     <LangVersion>7.2</LangVersion>
     <TreatWarningsAsErrors>True</TreatWarningsAsErrors>

README.md

@@ -137,8 +137,8 @@ The SDK is configurable, many of the settings are demonstrated through the sampl
 * Shutdown timeout: If there are events to send, how long to wait until shutdown
 * Accept compressed response
 * Compress request body
-* Breadcrumb level: Minimal log level to store as a breadcrumb
-* Event level: Minimal log level to send an event to Sentry
+* Breadcrumb level: Minimum log level to store as a breadcrumb
+* Event level: Minimum log level to send an event to Sentry
 * Disable duplicate event detection
 * Disable capture of global unhandled exceptions
 * Add event processor
@@ -179,9 +179,9 @@ An example using `IHub` for testability is [SentryLogger](https://github.com/get
 
 ## Compatibility
 
-The packages target **.NET Standard 2.0**. That means [it is compatible with](https://docs.microsoft.com/en-us/dotnet/standard/net-standard) the following versions or newer:
+The packages target **.NET Standard 2.0** and **.NET Framework 4.6.1**. That means [it is compatible with](https://docs.microsoft.com/en-us/dotnet/standard/net-standard) the following versions or newer:
 
-* .NET Framework 4.6.1 (4.7.2 advised)
+* .NET Framework 4.6.1
 * .NET Core 2.0
 * Mono 5.4
 * Xamarin.Android 8.0
@@ -195,9 +195,14 @@ Of those, we've tested (we run our unit/integration tests) against:
 * Mono 5.12 macOS and Linux (Travis-CI)
 * .NET Core 2.1 Windows, macOS and Linux
 
+### Sentry Protocol
+
+Looking for the types used by this SDK to send data to Sentry like *SentryEvent* and *SentryException*?
+They are released as a separate [NuGet Package called `Sentry.Protocol`](https://www.nuget.org/packages/Sentry.Protocol/) and [sources are on this GitHub repository](https://github.com/getsentry/sentry-dotnet-protocol).
+
 ### Legacy frameworks
 
-Sentry's [Raven SDK](https://github.com/getsentry/raven-csharp/), battle tested with over 400.000 downloads on NuGet has support to .NET Framework 3.5+.
+Sentry's [Raven SDK](https://github.com/getsentry/raven-csharp/), battle tested with over 640.000 downloads on NuGet has support to .NET Framework 3.5+.
 
 ## Resources
 * [![Gitter chat](https://img.shields.io/gitter/room/getsentry/dotnet.svg)](https://gitter.im/getsentry/dotnet)

src/Sentry/Extensibility/DisabledHub.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Threading.Tasks;
+using Sentry.Protocol;
 
 namespace Sentry.Extensibility
 {

src/Sentry/IHub.cs

@@ -1,3 +1,5 @@
+using Sentry.Protocol;
+
 namespace Sentry
 {
     /// <summary>

src/Sentry/ISentryClient.cs

@@ -1,3 +1,5 @@
+using Sentry.Protocol;
+
 namespace Sentry
 {
     /// <summary>

src/Sentry/Internal/Http/HttpTransport.cs

@@ -50,7 +50,7 @@ public async Task CaptureEventAsync(SentryEvent @event, CancellationToken cancel
 #if DEBUG
                 var body = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
                 var responseId = JsonSerializer.DeserializeObject<SentrySuccessfulResponseBody>(body)?.id;
-                Debug.Assert(@event.EventId.ToString("N") == responseId);
+                Debug.Assert(@event.EventId.ToString() == responseId);
 #endif
                 return;
             }

src/Sentry/Internal/Hub.cs

@@ -4,6 +4,7 @@
 using System.Threading.Tasks;
 using Sentry.Extensibility;
 using Sentry.Integrations;
+using Sentry.Protocol;
 
 namespace Sentry.Internal
 {

src/Sentry/Internal/OptionalHub.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Threading.Tasks;
 using Sentry.Extensibility;
+using Sentry.Protocol;
 
 namespace Sentry.Internal
 {

src/Sentry/Sentry.csproj

@@ -17,7 +17,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Sentry.PlatformAbstractions" Version="1.0.0" />
-    <PackageReference Include="Sentry.Protocol" Version="1.0.2" />
+    <PackageReference Include="Sentry.Protocol" Version="1.0.4" />
     <PackageReference Include="System.Collections.Immutable" Version="1.5.0" />
   </ItemGroup>
 

src/Sentry/SentryClient.cs

@@ -148,7 +148,7 @@ private SentryId DoSendEvent(SentryEvent @event, Scope scope)
             if (Worker.EnqueueEvent(@event))
             {
                 _options.DiagnosticLogger?.LogDebug("Event queued up.");
-                return (SentryId)@event.EventId;
+                return @event.EventId;
             }
 
             _options.DiagnosticLogger?.LogWarning("The attempt to queue the event failed. Items in queue: {0}",