fix: CaptureFeedback now applies event processors (#4942)

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -5,7 +5,11 @@
 ### Features
 
 - GA release for Sentry Metrics ([#5023](https://github.com/getsentry/sentry-dotnet/pull/5023))
- 
+
+### Fixes
+
+- Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](https://github.com/getsentry/sentry-dotnet/pull/4942))
+
 ## 6.2.0
 
 ### Features

src/Sentry/CaptureFeedbackErrorReason.cs

@@ -40,4 +40,8 @@ public enum CaptureFeedbackResult
     /// Capture failed because the <see cref="SentryFeedback.Message"/> message is empty.
     /// </summary>
     EmptyMessage,
+    /// <summary>
+    /// The <see cref="SentryFeedback"/> was discarded by an event processor.
+    /// </summary>
+    DroppedByEventProcessor,
 }

src/Sentry/Internal/DataCategory.cs

@@ -6,6 +6,7 @@ namespace Sentry.Internal;
     public static DataCategory Attachment = new("attachment");
     public static DataCategory Default = new("default");
     public static DataCategory Error = new("error");
+    public static DataCategory Feedback = new("feedback");
     public static DataCategory Internal = new("internal");
     public static DataCategory Security = new("security");
     public static DataCategory Session = new("session");

src/Sentry/Internal/SentryEventHelper.cs

@@ -4,7 +4,8 @@ namespace Sentry.Internal;
 
 internal static class SentryEventHelper
 {
-    public static SentryEvent? ProcessEvent(SentryEvent? evt, IEnumerable<ISentryEventProcessor> processors, SentryHint? hint, SentryOptions options)
+    public static SentryEvent? ProcessEvent(SentryEvent? evt, IEnumerable<ISentryEventProcessor> processors,
+        SentryHint? hint, SentryOptions options, DataCategory dataCategory)
     {
         if (evt == null)
         {
@@ -19,7 +20,7 @@ internal static class SentryEventHelper
             processedEvent = processor.DoProcessEvent(processedEvent, effectiveHint);
             if (processedEvent == null)
             {
-                options.ClientReportRecorder.RecordDiscardedEvent(DiscardReason.EventProcessor, DataCategory.Error);
+                options.ClientReportRecorder.RecordDiscardedEvent(DiscardReason.EventProcessor, dataCategory);
                 options.LogInfo("Event dropped by processor {0}", processor.GetType().Name);
                 break;
             }

src/Sentry/Platforms/Cocoa/SentrySdk.cs

@@ -295,7 +295,8 @@ private static bool SuppressNativeCrash(SentryOptions options, CocoaSdk.SentryEv
             }
 
             var sentryEvent = evt.ToSentryEvent();
-            if (SentryEventHelper.ProcessEvent(sentryEvent, manualProcessors, null, options) is not { } processedEvent)
+            if (SentryEventHelper.ProcessEvent(sentryEvent, manualProcessors, null, options, DataCategory.Error)
+                is not { } processedEvent)
             {
                 return null;
             }

src/Sentry/SentryClient.cs

@@ -117,12 +117,19 @@ public SentryId CaptureFeedback(SentryFeedback feedback, out CaptureFeedbackResu
             evt.Level = scope.Level;
         }
 
+        if (SentryEventHelper.ProcessEvent(evt, scope.GetAllEventProcessors(), hint, _options, DataCategory.Feedback)
+            is not { } processedEvent)
+        {
+            result = CaptureFeedbackResult.DroppedByEventProcessor;
+            return SentryId.Empty;  // Dropped by an event processor
+        }
+
         var attachments = hint.Attachments.ToList();
-        var envelope = Envelope.FromFeedback(evt, _options.DiagnosticLogger, attachments, scope.SessionUpdate);
+        var envelope = Envelope.FromFeedback(processedEvent, _options.DiagnosticLogger, attachments, scope.SessionUpdate);
         if (CaptureEnvelope(envelope))
         {
             result = CaptureFeedbackResult.Success;
-            return evt.EventId;
+            return processedEvent.EventId;
         }
         result = CaptureFeedbackResult.UnknownError;
         return SentryId.Empty;
@@ -345,7 +352,8 @@ private SentryId DoSendEvent(SentryEvent @event, SentryHint? hint, Scope? scope)
             }
         }
 
-        if (SentryEventHelper.ProcessEvent(@event, scope.GetAllEventProcessors(), hint, _options) is not { } processedEvent)
+        if (SentryEventHelper.ProcessEvent(@event, scope.GetAllEventProcessors(), hint, _options, DataCategory.Error)
+            is not { } processedEvent)
         {
             return SentryId.Empty;  // Dropped by an event processor
         }

test/Sentry.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt

@@ -51,6 +51,7 @@ namespace Sentry
         UnknownError = 1,
         DisabledHub = 2,
         EmptyMessage = 3,
+        DroppedByEventProcessor = 4,
     }
     public enum CheckInStatus
     {

test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt

@@ -51,6 +51,7 @@ namespace Sentry
         UnknownError = 1,
         DisabledHub = 2,
         EmptyMessage = 3,
+        DroppedByEventProcessor = 4,
     }
     public enum CheckInStatus
     {

test/Sentry.Tests/ApiApprovalTests.Run.DotNet9_0.verified.txt

@@ -51,6 +51,7 @@ namespace Sentry
         UnknownError = 1,
         DisabledHub = 2,
         EmptyMessage = 3,
+        DroppedByEventProcessor = 4,
     }
     public enum CheckInStatus
     {

test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt

@@ -51,6 +51,7 @@ namespace Sentry
         UnknownError = 1,
         DisabledHub = 2,
         EmptyMessage = 3,
+        DroppedByEventProcessor = 4,
     }
     public enum CheckInStatus
     {