Addressed OpenTelemetry trim warnings

Author: jamescrosswell

src/Sentry.OpenTelemetry/Sentry.OpenTelemetry.csproj

@@ -16,7 +16,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="OpenTelemetry" Version="1.5.0" />
+    <!-- Version 1.6.0 is the minimum version that does not have trim warnings   -->
+    <PackageReference Include="OpenTelemetry" Version="1.6.0" />
   </ItemGroup>
 
   <ItemGroup>

src/Sentry.OpenTelemetry/SentrySpanProcessor.cs

@@ -463,9 +463,12 @@ private void GenerateSentryErrorsFromOtelSpan(Activity activity, IDictionary<str
             Exception exception;
             try
             {
-                var type = Type.GetType(exceptionType)!;
-                exception = (Exception)Activator.CreateInstance(type, message)!;
-                exception.SetSentryMechanism("SentrySpanProcessor.ErrorSpan");
+                if (CreatePoorMansException(exceptionType, message) is not {} poorMansException)
+                {
+                    _options?.DiagnosticLogger?.LogWarning($"Unable to create poor man's exception with trimming enabled : {exceptionType}");
+                    continue;
+                }
+                exception = poorMansException;
             }
             catch
             {
@@ -491,4 +494,18 @@ private void GenerateSentryErrorsFromOtelSpan(Activity activity, IDictionary<str
             });
         }
     }
+
+    [UnconditionalSuppressMessage("Trimming", "IL2057", Justification = AotHelper.AvoidAtRuntime)]
+    private static Exception? CreatePoorMansException(string exceptionType, string message)
+    {
+        if (AotHelper.IsTrimmed)
+        {
+            return null;
+        }
+
+        var type = Type.GetType(exceptionType)!;
+        var exception = (Exception)Activator.CreateInstance(type, message)!;
+        exception.SetSentryMechanism("SentrySpanProcessor.ErrorSpan");
+        return exception;
+    }
 }

test/Sentry.OpenTelemetry.Tests/Sentry.OpenTelemetry.Tests.csproj

@@ -5,8 +5,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="OpenTelemetry" Version="1.5.0" />
-    <PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.5.0" />
+    <PackageReference Include="OpenTelemetry" Version="1.6.0" />
+    <PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.6.0" />
   </ItemGroup>
 
   <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">

test/Sentry.TrimTest/Sentry.TrimTest.csproj

@@ -9,13 +9,22 @@
     <!-- See https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming#show-all-warnings-with-test-app -->
     <PublishTrimmed>true</PublishTrimmed>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <TrimmerSingleWarn>false</TrimmerSingleWarn>
   </PropertyGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\..\src\Sentry\Sentry.csproj" />
+    <ProjectReference Include="..\..\src\Sentry.DiagnosticSource\Sentry.DiagnosticSource.csproj" />
+    <ProjectReference Include="..\..\src\Sentry.Extensions.Logging\Sentry.Extensions.Logging.csproj" />
     <ProjectReference Include="..\..\src\Sentry.Maui\Sentry.Maui.csproj" />
+    <ProjectReference Include="..\..\src\Sentry.OpenTelemetry\Sentry.OpenTelemetry.csproj" />
+    <ProjectReference Include="..\..\src\Sentry.Serilog\Sentry.Serilog.csproj" />
     <TrimmerRootAssembly Include="Sentry" />
+    <TrimmerRootAssembly Include="Sentry.DiagnosticSource" />
+    <TrimmerRootAssembly Include="Sentry.Extensions.Logging" />
     <TrimmerRootAssembly Include="Sentry.Maui" />
+    <TrimmerRootAssembly Include="Sentry.OpenTelemetry" />
+    <TrimmerRootAssembly Include="Sentry.Serilog" />
   </ItemGroup>
 
 </Project>