Add Trim test app

jamescrosswell · jamescrosswell · commit f0c22332f626 · 2024-12-12T11:03:09.000+13:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -187,6 +187,44 @@ jobs:
         with:
           path: integration-test
 
+
+  trim-analysis:
+    needs: build
+    name: Trim analysis
+    runs-on: macos-15
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+          fetch-depth: 2 # default is 1 and codecov needs > 1
+
+      # We use macOS for the final publishing build so we get all the iOS/macCatalyst targets in the packages
+      - name: Set Environment Variables
+        run: echo "CI_PUBLISHING_BUILD=true" >> $GITHUB_ENV
+
+      - name: Download sentry-native (macOS)
+        uses: actions/cache/restore@v4
+        with:
+          path: src/Sentry/Platforms/Native/sentry-native
+          key: sentry-native-macOS-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }}
+          fail-on-cache-miss: true
+
+      - name: Setup Environment
+        uses: ./.github/actions/environment
+
+      - name: Build Native Dependencies
+        uses: ./.github/actions/buildnative
+
+      - name: Install Android SDKs
+        if: runner.os == 'macOS'
+        run: |
+          dotnet build src/Sentry/Sentry.csproj -t:InstallAndroidDependencies -f:net8.0-android34.0 -p:AcceptAndroidSDKLicenses=True -p:AndroidSdkPath="/usr/local/lib/android/sdk/"
+
+      - name: Publish Test app
+        run: dotnet publish test/Sentry.TrimTest/Sentry.TrimTest.csproj -c Release -r osx-arm64
+
   test-solution-filters:
     runs-on: ubuntu-latest
     if: ${{ !startsWith(github.ref_name, 'release/') }}
diff --git a/Sentry-CI-Build-Linux.slnf b/Sentry-CI-Build-Linux.slnf
@@ -71,6 +71,7 @@
       "test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",
       "test\\Sentry.Testing\\Sentry.Testing.csproj",
       "test\\Sentry.Tests\\Sentry.Tests.csproj",
+      "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",
       "test\\SingleFileTestApp\\SingleFileTestApp.csproj"
     ]
   }
diff --git a/Sentry-CI-Build-Windows.slnf b/Sentry-CI-Build-Windows.slnf
@@ -74,6 +74,7 @@
       "test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",
       "test\\Sentry.Testing\\Sentry.Testing.csproj",
       "test\\Sentry.Tests\\Sentry.Tests.csproj",
+      "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",
       "test\\SingleFileTestApp\\SingleFileTestApp.csproj"
     ]
   }
diff --git a/Sentry-CI-Build-macOS.slnf b/Sentry-CI-Build-macOS.slnf
@@ -38,10 +38,10 @@
       "samples\\Sentry.Samples.Serilog\\Sentry.Samples.Serilog.csproj",
       "src\\Sentry.Analyzers\\Sentry.Analyzers.csproj",
       "src\\Sentry.Android.AssemblyReader\\Sentry.Android.AssemblyReader.csproj",
-      "src\\Sentry.AspNet\\Sentry.AspNet.csproj",
       "src\\Sentry.AspNetCore.Blazor.WebAssembly\\Sentry.AspNetCore.Blazor.WebAssembly.csproj",
       "src\\Sentry.AspNetCore.Grpc\\Sentry.AspNetCore.Grpc.csproj",
       "src\\Sentry.AspNetCore\\Sentry.AspNetCore.csproj",
+      "src\\Sentry.AspNet\\Sentry.AspNet.csproj",
       "src\\Sentry.Azure.Functions.Worker\\Sentry.Azure.Functions.Worker.csproj",
       "src\\Sentry.Bindings.Android\\Sentry.Bindings.Android.csproj",
       "src\\Sentry.Bindings.Cocoa\\Sentry.Bindings.Cocoa.csproj",
@@ -80,7 +80,8 @@
       "test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",
       "test\\Sentry.Testing\\Sentry.Testing.csproj",
       "test\\Sentry.Tests\\Sentry.Tests.csproj",
+      "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",
       "test\\SingleFileTestApp\\SingleFileTestApp.csproj"
     ]
   }
-}
+}
diff --git a/Sentry.sln b/Sentry.sln
@@ -193,6 +193,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Sentry.Analyzers.Tests", "t
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Sentry.Samples.Console.HeapDump", "samples\Sentry.Samples.Console.HeapDump\Sentry.Samples.Console.HeapDump.csproj", "{D7DF0B26-AD43-4F8B-9BFE-C4471CCC9821}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Sentry.TrimTest", "test\Sentry.TrimTest\Sentry.TrimTest.csproj", "{6030B748-0000-43B5-B8A8-399AA42F5229}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -520,6 +522,10 @@ Global
 		{D7DF0B26-AD43-4F8B-9BFE-C4471CCC9821}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{D7DF0B26-AD43-4F8B-9BFE-C4471CCC9821}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{D7DF0B26-AD43-4F8B-9BFE-C4471CCC9821}.Release|Any CPU.Build.0 = Release|Any CPU
+		{6030B748-0000-43B5-B8A8-399AA42F5229}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{6030B748-0000-43B5-B8A8-399AA42F5229}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{6030B748-0000-43B5-B8A8-399AA42F5229}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{6030B748-0000-43B5-B8A8-399AA42F5229}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -605,5 +611,6 @@ Global
 		{E36C8DCA-464E-41CB-B189-F58553AAA8D4} = {230B9384-90FD-4551-A5DE-1A5C197F25B6}
 		{5A17FEF9-07BB-47B8-9883-9C2CC93F09E8} = {6987A1CC-608E-4868-A02C-09D30C8B7B2D}
 		{D7DF0B26-AD43-4F8B-9BFE-C4471CCC9821} = {21B42F60-5802-404E-90F0-AEBCC56760C0}
+		{6030B748-0000-43B5-B8A8-399AA42F5229} = {6987A1CC-608E-4868-A02C-09D30C8B7B2D}
 	EndGlobalSection
 EndGlobal
diff --git a/SentryNoMobile.slnf b/SentryNoMobile.slnf
@@ -68,6 +68,7 @@
       "test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",
       "test\\Sentry.Testing\\Sentry.Testing.csproj",
       "test\\Sentry.Tests\\Sentry.Tests.csproj",
+      "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",
       "test\\SingleFileTestApp\\SingleFileTestApp.csproj"
     ]
   }
diff --git a/SentryNoSamples.slnf b/SentryNoSamples.slnf
@@ -43,7 +43,8 @@
       "test\\Sentry.Serilog.Tests\\Sentry.Serilog.Tests.csproj",
       "test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",
       "test\\Sentry.Testing\\Sentry.Testing.csproj",
-      "test\\Sentry.Tests\\Sentry.Tests.csproj"
+      "test\\Sentry.Tests\\Sentry.Tests.csproj",
+      "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj"
     ]
   }
 }
diff --git a/test/Sentry.TrimTest/Directory.Build.props b/test/Sentry.TrimTest/Directory.Build.props
@@ -0,0 +1,2 @@
+<!-- This file is here to prevent any from being used from parent directories. -->
+<Project />
diff --git a/test/Sentry.TrimTest/Directory.Build.targets b/test/Sentry.TrimTest/Directory.Build.targets
@@ -0,0 +1,2 @@
+<!-- This file is here to prevent any from being used from parent directories. -->
+<Project />
diff --git a/test/Sentry.TrimTest/Program.cs b/test/Sentry.TrimTest/Program.cs
@@ -0,0 +1,2 @@
+﻿// See https://aka.ms/new-console-template for more information
+Console.WriteLine("Hello, World!");
diff --git a/test/Sentry.TrimTest/README.md b/test/Sentry.TrimTest/README.md
@@ -0,0 +1,14 @@
+# Sentry Trimming Test App
+
+This project does not contain any unit or integration tests. However, if we are able to successfully publish it without 
+warning/error then Sentry should be trim compatible.
+
+To test this we need to publish the app with the following command:
+
+```bash
+dotnet publish -c Release -r <RID>
+```
+
+See:
+- [Show all warnings with test app](https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming#show-all-warnings-with-test-app)
+- [.NET RID Catalog](https://learn.microsoft.com/en-us/dotnet/core/rid-catalog)
diff --git a/test/Sentry.TrimTest/Sentry.TrimTest.csproj b/test/Sentry.TrimTest/Sentry.TrimTest.csproj
@@ -0,0 +1,18 @@
+﻿<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net9.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+
+    <!-- See https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming#show-all-warnings-with-test-app -->
+    <PublishTrimmed>true</PublishTrimmed>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\..\src\Sentry\Sentry.csproj" />
+    <TrimmerRootAssembly Include="Sentry" />
+  </ItemGroup>
+
+</Project>

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,7 @@`
`71`	`71`	`"test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",`
`72`	`72`	`"test\\Sentry.Testing\\Sentry.Testing.csproj",`
`73`	`73`	`"test\\Sentry.Tests\\Sentry.Tests.csproj",`
	`74`	`+ "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",`
`74`	`75`	`"test\\SingleFileTestApp\\SingleFileTestApp.csproj"`
`75`	`76`	`]`
`76`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@`
`74`	`74`	`"test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",`
`75`	`75`	`"test\\Sentry.Testing\\Sentry.Testing.csproj",`
`76`	`76`	`"test\\Sentry.Tests\\Sentry.Tests.csproj",`
	`77`	`+ "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",`
`77`	`78`	`"test\\SingleFileTestApp\\SingleFileTestApp.csproj"`
`78`	`79`	`]`
`79`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@`
`68`	`68`	`"test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",`
`69`	`69`	`"test\\Sentry.Testing\\Sentry.Testing.csproj",`
`70`	`70`	`"test\\Sentry.Tests\\Sentry.Tests.csproj",`
	`71`	`+ "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj",`
`71`	`72`	`"test\\SingleFileTestApp\\SingleFileTestApp.csproj"`
`72`	`73`	`]`
`73`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,8 @@`
`43`	`43`	`"test\\Sentry.Serilog.Tests\\Sentry.Serilog.Tests.csproj",`
`44`	`44`	`"test\\Sentry.Testing.CrashableApp\\Sentry.Testing.CrashableApp.csproj",`
`45`	`45`	`"test\\Sentry.Testing\\Sentry.Testing.csproj",`
`46`		`- "test\\Sentry.Tests\\Sentry.Tests.csproj"`
	`46`	`+ "test\\Sentry.Tests\\Sentry.Tests.csproj",`
	`47`	`+ "test\\Sentry.TrimTest\\Sentry.TrimTest.csproj"`
`47`	`48`	`]`
`48`	`49`	`}`
`49`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<!-- This file is here to prevent any from being used from parent directories. -->`
	`2`	`+<Project />`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// See https://aka.ms/new-console-template for more information`
	`2`	`+Console.WriteLine("Hello, World!");`