Cleanup (#2382)

* Relocate CLSCompliant attribute to msbuild property

* Move Android attributes

* Relocate InternalsVisibleTo attributes to MSBuild properties

* Remove old style attributes

* Bump Polyfill library to latest

* Bump Verify library to latest

Author: mattjohnsonpint

Directory.Build.props

@@ -104,4 +104,14 @@
     <SentryCLIDirectory>$(MSBuildThisFileDirectory)tools\sentry-cli\$(SentryCLIVersion)\</SentryCLIDirectory>
   </PropertyGroup>
 
+  <!-- Public key of .assets/Sentry.snk - not a secret.  Used by other InternalsVisibleTo entries throughout the solution. -->
+  <PropertyGroup>
+    <SentryPublicKey>002400000480000094000000060200000024000052534131000400000100010059964a931488bcdbd14657f1ee0df32df61b57b3d14d7290c262c2cc9ddaad6ec984044f761f778e1823049d2cb996a4f58c8ea5b46c37891414cb34b4036b1c178d7b582289d2eef3c0f1e9b692c229a306831ee3d371d9e883f0eb0f74aeac6c6ab8c85fd1ec04b267e15a31532c4b4e2191f5980459db4dce0081f1050fb8</SentryPublicKey>
+  </PropertyGroup>
+
+  <!-- Allow NSubstitute dynamic proxies to access any internal API.  Its PublicKey is not a secret. -->
+  <ItemGroup>
+    <InternalsVisibleTo Include="DynamicProxyGenAssembly2" PublicKey="0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7" />
+  </ItemGroup>
+
 </Project>

Directory.Build.targets

@@ -34,6 +34,13 @@
     <Compile Remove="**\Tizen\**\*.cs" />
   </ItemGroup>
 
+  <!-- Allow setting CLSCompliant via property in any csproj -->
+  <ItemGroup>
+    <AssemblyAttribute Include="CLSCompliantAttribute" Condition="'$(CLSCompliant)' == 'true'">
+      <_Parameter1>true</_Parameter1>
+    </AssemblyAttribute>
+  </ItemGroup>
+
   <!-- Workaround for https://github.com/xamarin/xamarin-macios/issues/15897 -->
   <Target Name="_SetPublishFolderTypeNoneOnDocFileItems"
     BeforeTargets="_ComputePublishLocation"

benchmarks/Sentry.Benchmarks/Properties/GlobalSuppressions.cs

@@ -26,4 +26,8 @@
     <PackageReference Remove="SIL.ReleaseTasks" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="Sentry.Android.AssemblyReader.Tests" PublicKey="$(SentryPublicKey)" />
+  </ItemGroup>
+
 </Project>

src/Sentry.Android.AssemblyReader/Properties/AssemblyInfo.cs

@@ -16,4 +16,8 @@
     <ProjectReference Include="..\Sentry.DiagnosticSource\Sentry.DiagnosticSource.csproj" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="Sentry.AspNet.Tests" PublicKey="$(SentryPublicKey)" />
+  </ItemGroup>
+
 </Project>

src/Sentry.Android.AssemblyReader/Sentry.Android.AssemblyReader.csproj

@@ -15,4 +15,8 @@
     <PackageReference Include="Grpc.AspNetCore.Server" Version="2.40.0" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="Sentry.AspNetCore.Grpc.Tests" PublicKey="$(SentryPublicKey)" />
+  </ItemGroup>
+
 </Project>