Skip to content

Incorrect statistics for crashed state. #1152

@beyondkmp

Description

@beyondkmp

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Electron SDK Version

5.11.0

Electron Version

34.0.0

What platform are you using?

Windows

Link to Sentry event

https://jupiter-ct.sentry.io/issues/6104662640/events/b6c61dca18e84a618af8e7be368b7657/?project=4508278211739648

No response

Steps to Reproduce

  1. start
  2. generate network error

Expected Result

Do not include it in the crashed statistics.

Actual Result

Include it in the crashed statistics.

This is caused getsentry/sentry-javascript#15072.

Currently, any event with level "fatal" is marked as crashed. However, this type of network error was not previously counted as crashed. After this change, it started being included.
I think we should not only check if the level is "fatal", but also verify whether the attachment's type is "event.minidump". Only when both conditions are true should it be considered as crashed.

Image

Alternatively, you can fix it by checking: if exceptions exist and all of them are handled, then crash should be set to false.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Status

    Waiting for: Community

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions