-
-
Notifications
You must be signed in to change notification settings - Fork 60
Closed as not planned
Labels
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Electron SDK Version
5.11.0
Electron Version
34.0.0
What platform are you using?
Windows
Link to Sentry event
No response
Steps to Reproduce
- start
- generate network error
Expected Result
Do not include it in the crashed statistics.
Actual Result
Include it in the crashed statistics.
This is caused getsentry/sentry-javascript#15072.
Currently, any event with level "fatal" is marked as crashed. However, this type of network error was not previously counted as crashed. After this change, it started being included.
I think we should not only check if the level is "fatal", but also verify whether the attachment's type is "event.minidump". Only when both conditions are true should it be considered as crashed.
Alternatively, you can fix it by checking: if exceptions exist and all of them are handled, then crash should be set to false.
Metadata
Metadata
Assignees
Labels
Projects
Status
Waiting for: Community

