WIP

Author: solnic

test_integrations/tracing/tests/tracing.spec.ts

@@ -477,24 +477,44 @@ test.describe("Tracing", () => {
       );
       expect(transactionEvents.length).toBeGreaterThan(0);
 
-      // Find API transaction and LiveView transaction
+      // Find API transaction
       const apiTransaction = transactionEvents.find(
         (event) =>
           event.transaction?.includes("/api/data") ||
           (event.contexts?.trace?.data as any)?.["http.route"] === "/api/data"
       );
-      const liveViewTransaction = transactionEvents.find(
+      expect(apiTransaction).toBeDefined();
+
+      // Find LiveView HTTP transaction (static render - no DB queries here)
+      const liveViewHttpTransaction = transactionEvents.find(
         (event) =>
-          event.transaction?.includes("/users") ||
-          (event.contexts?.trace?.data as any)?.["http.route"] === "/users"
+          event.contexts?.trace?.op === "http.server" &&
+          ((event.contexts?.trace?.data as any)?.["http.route"] === "/users" ||
+           event.transaction?.includes("/users"))
       );
+      expect(liveViewHttpTransaction).toBeDefined();
 
-      expect(apiTransaction).toBeDefined();
-      expect(liveViewTransaction).toBeDefined();
+      // Find LiveView mount transaction (WebSocket - DB queries run here)
+      // The mount transaction is created by opentelemetry_phoenix for LiveView WebSocket
+      // There may be multiple mount transactions - find the one with spans (where DB query ran)
+      const liveViewMountTransactions = transactionEvents.filter(
+        (event) =>
+          event.transaction?.includes("UserLive.Index.mount") ||
+          event.transaction?.includes(".mount")
+      );
+      
+      // Find mount transaction that has spans (prefer one with DB spans)
+      const liveViewMountTransaction = liveViewMountTransactions.find(tx => {
+        const spans = (tx as any).spans || [];
+        return spans.length > 0;
+      }) || liveViewMountTransactions[0];
+      
+      expect(liveViewMountTransaction).toBeDefined();
 
-      // Both should have valid trace IDs
+      // All should have valid trace IDs
       expect(apiTransaction?.contexts?.trace?.trace_id).toMatch(/^[a-f0-9]{32}$/);
-      expect(liveViewTransaction?.contexts?.trace?.trace_id).toMatch(/^[a-f0-9]{32}$/);
+      expect(liveViewHttpTransaction?.contexts?.trace?.trace_id).toMatch(/^[a-f0-9]{32}$/);
+      expect(liveViewMountTransaction?.contexts?.trace?.trace_id).toMatch(/^[a-f0-9]{32}$/);
 
       // Verify the API transaction has database spans
       const apiSpans = (apiTransaction as any)?.spans || [];
@@ -508,17 +528,29 @@ test.describe("Tracing", () => {
         expect(dbSpan.description).toMatch(/SELECT/i);
       });
 
-      // Check LiveView transaction for spans (optional, may not have them in all cases)
-      const liveViewSpans = (liveViewTransaction as any)?.spans || [];
-      if (liveViewSpans.length > 0) {
-        const liveViewDbSpans = liveViewSpans.filter((span: any) => span.op === "db");
-        if (liveViewDbSpans.length > 0) {
-          liveViewDbSpans.forEach((dbSpan: any) => {
-            expect(dbSpan.data["db.system"]).toBeDefined();
-            expect(dbSpan.data["db.statement"]).toBeDefined();
-          });
-        }
-      }
+      // LiveView HTTP transaction should NOT have DB spans
+      // (static render doesn't run Ecto query because connected?(socket) == false)
+      const httpSpans = (liveViewHttpTransaction as any)?.spans || [];
+      const httpDbSpans = httpSpans.filter((span: any) => span.op === "db");
+      expect(httpDbSpans.length).toBe(0);
+
+      // LiveView mount transaction MUST have DB spans
+      // (WebSocket mount runs Ecto query because connected?(socket) == true)
+      const mountSpans = (liveViewMountTransaction as any)?.spans || [];
+      expect(mountSpans.length).toBeGreaterThan(0);
+
+      const mountDbSpans = mountSpans.filter((span: any) => span.op === "db");
+      expect(mountDbSpans.length).toBeGreaterThan(0);
+
+      // Verify mount DB spans have proper structure
+      mountDbSpans.forEach((dbSpan: any) => {
+        expect(dbSpan.span_id).toMatch(/^[a-f0-9]{16}$/);
+        expect(dbSpan.trace_id).toMatch(/^[a-f0-9]{32}$/);
+        expect(dbSpan.data["db.system"]).toBeDefined();
+        expect(dbSpan.data["db.statement"]).toBeDefined();
+        expect(dbSpan.data["db.statement"]).toMatch(/users/i);
+        expect(dbSpan.description).toMatch(/SELECT/i);
+      });
     });
   });
 });