Fix on_mount LiveView hook when given :not_mounted_at_router (#742)

Co-authored-by: Savannah Manning <[email protected]>

Author: savhappy

lib/sentry/live_view_hook.ex

@@ -53,8 +53,9 @@ if Code.ensure_loaded?(Phoenix.LiveView) do
     # https://develop.sentry.dev/sdk/event-payloads/request/
 
     @doc false
-    @spec on_mount(:default, map(), map(), struct()) :: {:cont, struct()}
-    def on_mount(:default, params, _session, socket), do: on_mount(params, socket)
+    @spec on_mount(:default, map() | :not_mounted_at_router, map(), struct()) :: {:cont, struct()}
+    def on_mount(:default, %{} = params, _session, socket), do: on_mount(params, socket)
+    def on_mount(:default, :not_mounted_at_router, _session, socket), do: {:cont, socket}
 
     ## Helpers
 

test/sentry/live_view_hook_test.exs

@@ -31,11 +31,40 @@ defmodule SentryTest.LiveComponent do
   end
 end
 
+defmodule SentryTest.DeadLive do
+  use Phoenix.LiveView
+  on_mount Sentry.LiveViewHook
+
+  @impl true
+  def render(assigns) do
+    ~H"""
+    <div>I'm being live_rendered!</div>
+    """
+  end
+end
+
+defmodule SentryTest.PageController do
+  use Phoenix.Controller
+  use Phoenix.Component
+
+  def page(conn, _params) do
+    assigns = %{conn: conn}
+
+    rendered = ~H"""
+    I'm a controller! <br><%= live_render(@conn, SentryTest.DeadLive, id: "live-render-id") %>
+    """
+
+    content = Phoenix.HTML.Safe.to_iodata(rendered)
+    text(conn, content)
+  end
+end
+
 defmodule SentryTest.Router do
   use Phoenix.Router
   import Phoenix.LiveView.Router
 
   scope "/" do
+    get "/dead_test", SentryTest.PageController, :page
     live "/hook_test", SentryTest.Live
   end
 end
@@ -126,6 +155,15 @@ defmodule Sentry.LiveViewHookTest do
     assert html =~ "I&#39;m a LiveComponent"
   end
 
+  test "does not log an error when a liveview is a child of a non-live phoenix controller/view",
+       %{conn: conn} do
+    conn = get(conn, "/dead_test")
+
+    assert response = text_response(conn, 200)
+    assert response =~ "I'm being live_rendered!"
+    assert Logger.metadata() == []
+  end
+
   defp get_sentry_context(view) do
     {:dictionary, pdict} = Process.info(view.pid, :dictionary)