Skip to content

Commit 37e3cc6

Browse files
committed
Address requested review changes.
1 parent 51fd837 commit 37e3cc6

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,3 @@
33
erl_crash.dump
44
*.ez
55
/doc
6-
.DS_Store
7-
.elixir_ls/

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ For optional settings check the [docs](https://hexdocs.pm/sentry/readme.html).
118118
| `source_code_path_pattern` | False | `"**/*.ex"` | |
119119
| `filter` | False | | Module where the filter rules are defined (see [Filtering Exceptions](https://hexdocs.pm/sentry/Sentry.html#module-filtering-exceptions)) |
120120
| `json_library` | False | `Jason` | |
121-
| `log_level` | False | `:warn` | |
121+
| `log_level` | False | `:warn` | This sets the log level used when Sentry fails to send an event due to an invalid event or API error. |
122122

123123
An example production config might look like this:
124124

lib/sentry/config.ex

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ defmodule Sentry.Config do
1414
@default_context_lines 3
1515
@default_sample_rate 1.0
1616

17-
@permitted_log_level_atom_values ~w(debug info warn error)a
18-
@permitted_log_level_string_values ~w(debug info warn error)
19-
@permitted_log_level_values @permitted_log_level_atom_values ++
20-
@permitted_log_level_string_values
17+
@permitted_log_level_values ~w(debug info warn error)a
2118

2219
def validate_config! do
2320
end
@@ -134,8 +131,7 @@ defmodule Sentry.Config do
134131

135132
def log_level do
136133
case get_config(:log_level, default: :warn, check_dsn: false) do
137-
value when value in @permitted_log_level_atom_values -> value
138-
value when value in @permitted_log_level_string_values -> String.to_existing_atom(value)
134+
value when value in @permitted_log_level_values -> value
139135
value -> value
140136
end
141137
end

0 commit comments

Comments
 (0)