Merge pull request #228 from getsentry/handle-error-send-test-event

Handle :error when sending test event

Author: mitchellhenke

lib/mix/tasks/sentry.send_test_event.ex

@@ -53,6 +53,8 @@ defmodule Mix.Tasks.Sentry.SendTestEvent do
       case result do
         {:ok, id} ->
           Mix.shell.info "Test event sent!  Event ID: #{id}"
+        :error ->
+          Mix.shell.info "Error sending event!"
         :excluded ->
           Mix.shell.info "No test event was sent because the event was excluded by a filter"
       end

lib/sentry/client.ex

@@ -139,8 +139,8 @@ defmodule Sentry.Client do
         error_header = :proplists.get_value("X-Sentry-Error", headers, "")
         log_api_error("#{body}\nReceived #{status} from Sentry server: #{error_header}")
         :error
-      _ ->
-        log_api_error(body)
+      e ->
+        log_api_error("#{inspect(e)}\n#{body}")
         :error
     end
   end

test/mix/sentry.send_test_event_test.exs

@@ -1,6 +1,7 @@
 defmodule Mix.Tasks.Sentry.SendTestEventTest do
   use ExUnit.Case
   import ExUnit.CaptureIO
+  import ExUnit.CaptureLog
   import Sentry.TestEnvironmentHelper
 
   test "prints if environment_name is not in included_environments" do
@@ -46,4 +47,29 @@ defmodule Mix.Tasks.Sentry.SendTestEventTest do
     Test event sent!  Event ID: 340
     """
   end
+
+  test "handles :error when Sentry server is failing" do
+    bypass = Bypass.open
+    Bypass.expect bypass, fn conn ->
+      {:ok, _body, conn} = Plug.Conn.read_body(conn)
+      Plug.Conn.resp(conn, 500, ~s<{"id": "340"}>)
+    end
+    modify_env(:sentry, [dsn: "http://public:secret@localhost:#{bypass.port}/1"])
+    assert capture_log(fn ->
+      assert capture_io(fn ->
+        Mix.Tasks.Sentry.SendTestEvent.run([])
+      end) == """
+      Client configuration:
+      server: http://localhost:#{bypass.port}/api/1/store/
+      public_key: public
+      secret_key: secret
+      included_environments: [:test]
+      current environment_name: :test
+      hackney_opts: [recv_timeout: 50]
+
+      Sending test event...
+      Error sending event!
+      """
+    end) =~ "Failed to send Sentry event"
+  end
 end