Merge pull request #315 from getsentry/fix-weird-stacktrace

coerce stacktrace

Author: mitchellhenke

lib/sentry/event.ex

@@ -73,7 +73,9 @@ defmodule Sentry.Event do
 
     message = Keyword.get(opts, :message)
 
-    stacktrace = Keyword.get(opts, :stacktrace, [])
+    stacktrace =
+      Keyword.get(opts, :stacktrace, [])
+      |> coerce_stacktrace()
 
     fingerprint = Keyword.get(opts, :fingerprint, ["{{ default }}"])
 
@@ -238,6 +240,10 @@ defmodule Sentry.Event do
     Exception.format_mfa(m, f, arity_to_integer(a))
   end
 
+  def culprit_from_stacktrace([{m, f, a} | _]) do
+    Exception.format_mfa(m, f, arity_to_integer(a))
+  end
+
   @doc """
   Builds a map from argument value list.  For Sentry, typically the
   key in the map would be the name of the variable, but we don't have that
@@ -276,4 +282,7 @@ defmodule Sentry.Event do
   end
 
   defp module_split(module), do: module_split(String.Chars.to_string(module))
+
+  defp coerce_stacktrace({m, f, a}), do: [{m, f, a, []}]
+  defp coerce_stacktrace(stacktrace), do: stacktrace
 end

test/sentry_test.exs

@@ -61,4 +61,35 @@ defmodule SentryTest do
 
     Bypass.pass(bypass)
   end
+
+  test "handles three element tuple as stacktrace" do
+    bypass = Bypass.open()
+
+    Bypass.expect(bypass, fn conn ->
+      assert conn.request_path == "/api/1/store/"
+      assert conn.method == "POST"
+      {:ok, body, conn} = Plug.Conn.read_body(conn)
+      {:ok, json} = Jason.decode(body)
+      assert json["culprit"] == "GenServer.call/3"
+      assert List.first(json["exception"])["value"] == "Erlang error: :timeout"
+      Plug.Conn.send_resp(conn, 200, ~s<{"id": "340"}>)
+    end)
+
+    modify_env(
+      :sentry,
+      dsn: "http://public:secret@localhost:#{bypass.port}/1"
+    )
+
+    Process.flag(:trap_exit, true)
+
+    {:ok, pid} = Sentry.TestGenServer.start_link(self())
+    spawn_pid = spawn_link(fn -> GenServer.call(pid, {:sleep, 100}, 0) end)
+
+    receive do
+      {:EXIT, ^spawn_pid, {reason, stack}} ->
+        Sentry.capture_exception(reason, stacktrace: stack)
+    end
+
+    Bypass.pass(bypass)
+  end
 end

test/support/test_gen_server.exs

@@ -19,6 +19,11 @@ defmodule Sentry.TestGenServer do
     {:ok, pid}
   end
 
+  def handle_call({:sleep, milliseconds}, _from, state) do
+    :timer.sleep(milliseconds)
+    {:reply, :ok, state}
+  end
+
   def handle_info(:throw, _state) do
     throw("I am throwing")
   end