Generic transactions spans parsing

danschultzer · danschultzer · commit 4af61b937e92 · 2024-12-14T08:55:50.000-08:00
diff --git a/lib/sentry/opentelemetry/span_processor.ex b/lib/sentry/opentelemetry/span_processor.ex
diff --git a/lib/sentry/transaction.ex b/lib/sentry/transaction.ex
@@ -12,8 +12,6 @@ defmodule Sentry.Transaction do
     :transaction,
     :transaction_info,
     :contexts,
-    :request,
-    :data,
     :measurements,
     :spans,
     type: "transaction"
diff --git a/mix.exs b/mix.exs
@@ -115,7 +115,8 @@ defmodule Sentry.Mixfile do
 
       # Required by Tracing
       {:opentelemetry, "~> 1.5"},
-      {:opentelemetry_api, "~> 1.3"}
+      {:opentelemetry_api, "~> 1.3"},
+      {:opentelemetry_semantic_conventions, "~> 1.0"}
     ]
   end
 
diff --git a/mix.lock b/mix.lock
@@ -34,7 +34,7 @@
   "oban": {:hex, :oban, "2.18.3", "1608c04f8856c108555c379f2f56bc0759149d35fa9d3b825cb8a6769f8ae926", [:mix], [{:ecto_sql, "~> 3.10", [hex: :ecto_sql, repo: "hexpm", optional: false]}, {:ecto_sqlite3, "~> 0.9", [hex: :ecto_sqlite3, repo: "hexpm", optional: true]}, {:jason, "~> 1.1", [hex: :jason, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.16", [hex: :postgrex, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "36ca6ca84ef6518f9c2c759ea88efd438a3c81d667ba23b02b062a0aa785475e"},
   "opentelemetry": {:hex, :opentelemetry, "1.5.0", "7dda6551edfc3050ea4b0b40c0d2570423d6372b97e9c60793263ef62c53c3c2", [:rebar3], [{:opentelemetry_api, "~> 1.4", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}], "hexpm", "cdf4f51d17b592fc592b9a75f86a6f808c23044ba7cf7b9534debbcc5c23b0ee"},
   "opentelemetry_api": {:hex, :opentelemetry_api, "1.4.0", "63ca1742f92f00059298f478048dfb826f4b20d49534493d6919a0db39b6db04", [:mix, :rebar3], [], "hexpm", "3dfbbfaa2c2ed3121c5c483162836c4f9027def469c41578af5ef32589fcfc58"},
-  "opentelemetry_semantic_conventions": {:hex, :opentelemetry_semantic_conventions, "0.2.0", "b67fe459c2938fcab341cb0951c44860c62347c005ace1b50f8402576f241435", [:mix, :rebar3], [], "hexpm", "d61fa1f5639ee8668d74b527e6806e0503efc55a42db7b5f39939d84c07d6895"},
+  "opentelemetry_semantic_conventions": {:hex, :opentelemetry_semantic_conventions, "1.27.0", "acd0194a94a1e57d63da982ee9f4a9f88834ae0b31b0bd850815fe9be4bbb45f", [:mix, :rebar3], [], "hexpm", "9681ccaa24fd3d810b4461581717661fd85ff7019b082c2dff89c7d5b1fc2864"},
   "parse_trans": {:hex, :parse_trans, "3.4.1", "6e6aa8167cb44cc8f39441d05193be6e6f4e7c2946cb2759f015f8c56b76e5ff", [:rebar3], [], "hexpm", "620a406ce75dada827b82e453c19cf06776be266f5a67cff34e1ef2cbb60e49a"},
   "phoenix": {:hex, :phoenix, "1.7.17", "2fcdceecc6fb90bec26fab008f96abbd0fd93bc9956ec7985e5892cf545152ca", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "50e8ad537f3f7b0efb1509b2f75b5c918f697be6a45d48e49a30d3b7c0e464c9"},
   "phoenix_html": {:hex, :phoenix_html, "4.1.1", "4c064fd3873d12ebb1388425a8f2a19348cef56e7289e1998e2d2fa758aa982e", [:mix], [], "hexpm", "f2f2df5a72bc9a2f510b21497fd7d2b86d932ec0598f0210fed4114adc546c6f"},
diff --git a/test/sentry/opentelemetry/span_processor_test.exs b/test/sentry/opentelemetry/span_processor_test.exs
@@ -50,6 +50,7 @@ defmodule Sentry.Opentelemetry.SpanProcessorTest do
     assert transaction_data.environment == "test"
     assert transaction_data.type == "transaction"
     assert transaction_data.op == "child_instrumented_function_one"
+    assert transaction_data.transaction_info == %{source: :custom}
     assert_valid_iso8601(transaction_data.timestamp)
     assert_valid_iso8601(transaction_data.start_timestamp)
     assert transaction_data.timestamp > transaction_data.start_timestamp
diff --git a/test_integrations/phoenix_app/lib/phoenix_app/application.ex b/test_integrations/phoenix_app/lib/phoenix_app/application.ex
@@ -14,7 +14,7 @@ defmodule PhoenixApp.Application do
     })
 
     # OpentelemetryBandit.setup()
-    OpentelemetryPhoenix.setup()
+    OpentelemetryPhoenix.setup(adapter: :bandit)
     OpentelemetryOban.setup()
     OpentelemetryEcto.setup([:phoenix_app, :repo], db_statement: :enabled)
 
diff --git a/test_integrations/phoenix_app/mix.exs b/test_integrations/phoenix_app/mix.exs
@@ -66,7 +66,10 @@ defmodule PhoenixApp.MixProject do
       {:bypass, "~> 2.1", only: :test},
       {:opentelemetry, "~> 1.5"},
       {:opentelemetry_api, "~> 1.3"},
-      {:opentelemetry_phoenix, "~> 1.2"},
+      {:opentelemetry_phoenix, "~> 2.0"},
+      # TODO: Remove when opentelemetry_oban upstream has been updated
+      # from opentelemetry_semantic_conventions 0.2 to 1.0
+      {:opentelemetry_semantic_conventions, "~> 1.0", override: true},
       {:opentelemetry_oban, "~> 1.1"},
       # {:opentelemetry_bandit, "~> 0.1.4", github: "solnic/opentelemetry-bandit", depth: 1},
       {:opentelemetry_ecto, "~> 1.2"},
diff --git a/test_integrations/phoenix_app/mix.lock b/test_integrations/phoenix_app/mix.lock
@@ -39,10 +39,11 @@
   "opentelemetry_bandit": {:git, "https://github.com/solnic/opentelemetry-bandit.git", "1e00505fb3bb02001a3400f8a807cd1c7f7f957d", []},
   "opentelemetry_ecto": {:hex, :opentelemetry_ecto, "1.2.0", "2382cb47ddc231f953d3b8263ed029d87fbf217915a1da82f49159d122b64865", [:mix], [{:opentelemetry_api, "~> 1.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_process_propagator, "~> 0.2", [hex: :opentelemetry_process_propagator, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "70dfa2e79932e86f209df00e36c980b17a32f82d175f0068bf7ef9a96cf080cf"},
   "opentelemetry_oban": {:hex, :opentelemetry_oban, "1.1.1", "519e9ba60d3dc3483ad2df3fade131d47056e0dae74f0724c8a40b9718f089d1", [:mix], [{:oban, "~> 2.0", [hex: :oban, repo: "hexpm", optional: false]}, {:opentelemetry_api, "~> 1.2", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_semantic_conventions, "~> 0.2", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}, {:opentelemetry_telemetry, "~> 1.1", [hex: :opentelemetry_telemetry, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ae6aed431626a94a4bb6bf5b268247ced687ec8f99eced6887e3754f9d3a2089"},
-  "opentelemetry_phoenix": {:hex, :opentelemetry_phoenix, "1.2.0", "b8a53ee595b24970571a7d2fcaef3e4e1a021c68e97cac163ca5d9875fad5e9f", [:mix], [{:nimble_options, "~> 0.5 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:opentelemetry_api, "~> 1.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_process_propagator, "~> 0.2", [hex: :opentelemetry_process_propagator, repo: "hexpm", optional: false]}, {:opentelemetry_semantic_conventions, "~> 0.2", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}, {:opentelemetry_telemetry, "~> 1.0", [hex: :opentelemetry_telemetry, repo: "hexpm", optional: false]}, {:plug, ">= 1.11.0", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "acab991d14ed3efc3f780c5a20cabba27149cf731005b1cc6454c160859debe5"},
+  "opentelemetry_phoenix": {:hex, :opentelemetry_phoenix, "2.0.0", "3a22f620a26613ba02e7289238da145c2ddcd58bd37b780b200080139d24b176", [:mix], [{:nimble_options, "~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:opentelemetry_api, "~> 1.4", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_process_propagator, "~> 0.3", [hex: :opentelemetry_process_propagator, repo: "hexpm", optional: false]}, {:opentelemetry_semantic_conventions, "~> 1.27", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}, {:opentelemetry_telemetry, "~> 1.1", [hex: :opentelemetry_telemetry, repo: "hexpm", optional: false]}, {:otel_http, "~> 0.2", [hex: :otel_http, repo: "hexpm", optional: false]}, {:plug, ">= 1.11.0", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "c2c0969c561a87703cda64e9f0c37e9dec6dceee11c2d2eafef8d3f4138ec364"},
   "opentelemetry_process_propagator": {:hex, :opentelemetry_process_propagator, "0.3.0", "ef5b2059403a1e2b2d2c65914e6962e56371570b8c3ab5323d7a8d3444fb7f84", [:mix, :rebar3], [{:opentelemetry_api, "~> 1.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}], "hexpm", "7243cb6de1523c473cba5b1aefa3f85e1ff8cc75d08f367104c1e11919c8c029"},
-  "opentelemetry_semantic_conventions": {:hex, :opentelemetry_semantic_conventions, "0.2.0", "b67fe459c2938fcab341cb0951c44860c62347c005ace1b50f8402576f241435", [:mix, :rebar3], [], "hexpm", "d61fa1f5639ee8668d74b527e6806e0503efc55a42db7b5f39939d84c07d6895"},
+  "opentelemetry_semantic_conventions": {:hex, :opentelemetry_semantic_conventions, "1.27.0", "acd0194a94a1e57d63da982ee9f4a9f88834ae0b31b0bd850815fe9be4bbb45f", [:mix, :rebar3], [], "hexpm", "9681ccaa24fd3d810b4461581717661fd85ff7019b082c2dff89c7d5b1fc2864"},
   "opentelemetry_telemetry": {:hex, :opentelemetry_telemetry, "1.1.2", "410ab4d76b0921f42dbccbe5a7c831b8125282850be649ee1f70050d3961118a", [:mix, :rebar3], [{:opentelemetry_api, "~> 1.3", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.1", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "641ab469deb181957ac6d59bce6e1321d5fe2a56df444fc9c19afcad623ab253"},
+  "otel_http": {:hex, :otel_http, "0.2.0", "b17385986c7f1b862f5d577f72614ecaa29de40392b7618869999326b9a61d8a", [:rebar3], [], "hexpm", "f2beadf922c8cfeb0965488dd736c95cc6ea8b9efce89466b3904d317d7cc717"},
   "parse_trans": {:hex, :parse_trans, "3.4.1", "6e6aa8167cb44cc8f39441d05193be6e6f4e7c2946cb2759f015f8c56b76e5ff", [:rebar3], [], "hexpm", "620a406ce75dada827b82e453c19cf06776be266f5a67cff34e1ef2cbb60e49a"},
   "phoenix": {:hex, :phoenix, "1.7.17", "2fcdceecc6fb90bec26fab008f96abbd0fd93bc9956ec7985e5892cf545152ca", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "50e8ad537f3f7b0efb1509b2f75b5c918f697be6a45d48e49a30d3b7c0e464c9"},
   "phoenix_ecto": {:hex, :phoenix_ecto, "4.6.3", "f686701b0499a07f2e3b122d84d52ff8a31f5def386e03706c916f6feddf69ef", [:mix], [{:ecto, "~> 3.5", [hex: :ecto, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 2.14.2 or ~> 3.0 or ~> 4.1", [hex: :phoenix_html, repo: "hexpm", optional: true]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: false]}, {:postgrex, "~> 0.16 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}], "hexpm", "909502956916a657a197f94cc1206d9a65247538de8a5e186f7537c895d95764"},
diff --git a/test_integrations/phoenix_app/test/phoenix_app/oban_test.exs b/test_integrations/phoenix_app/test/phoenix_app/oban_test.exs
@@ -28,17 +28,16 @@ defmodule Sentry.Integrations.Phoenix.ObanTest do
 
     [transaction] = transactions
 
-    assert transaction.transaction == "Sentry.Integrations.Phoenix.ObanTest.TestWorker"
-    assert transaction.transaction_info == %{source: "task"}
+    assert transaction.transaction == "Sentry.Integrations.Phoenix.ObanTest.TestWorker process"
+    assert transaction.transaction_info == %{source: :custom}
 
     trace = transaction.contexts.trace
     assert trace.origin == "opentelemetry_oban"
-    assert trace.op == "queue.process"
-    assert trace.data.id
-    assert trace.data.queue == "default"
-    assert trace.data.retry_count == 1
-    assert trace.data.latency > 0
+    assert trace.op == "Sentry.Integrations.Phoenix.ObanTest.TestWorker process"
+    assert trace.data["oban.job.job_id"]
+    assert trace.data["messaging.destination"] == "default"
+    assert trace.data["oban.job.attempt"] == 1
 
-    assert [] = transaction.spans
+    assert [_span] = transaction.spans
   end
 end
diff --git a/test_integrations/phoenix_app/test/phoenix_app/repo_test.exs b/test_integrations/phoenix_app/test/phoenix_app/repo_test.exs
@@ -20,8 +20,8 @@ defmodule PhoenixApp.RepoTest do
 
     assert [transaction] = transactions
 
-    assert transaction.transaction_info == %{source: "component"}
-    assert transaction.contexts.trace.op == "db.sql.ecto"
+    assert transaction.transaction_info == %{source: :custom}
+    assert transaction.contexts.trace.op == "db"
     assert String.starts_with?(transaction.contexts.trace.description, "SELECT")
     assert transaction.contexts.trace.data["db.system"] == :sqlite
   end
diff --git a/test_integrations/phoenix_app/test/phoenix_app_web/controllers/transaction_test.exs b/test_integrations/phoenix_app/test/phoenix_app_web/controllers/transaction_test.exs
@@ -10,6 +10,8 @@ defmodule Sentry.Integrations.Phoenix.TransactionTest do
   end
 
   test "GET /transaction", %{conn: conn} do
+    # TODO: Wrap this in a transaction that the web server usually
+    # would wrap it in.
     get(conn, ~p"/transaction")
 
     transactions = Sentry.Test.pop_sentry_transactions()
@@ -18,54 +20,57 @@ defmodule Sentry.Integrations.Phoenix.TransactionTest do
 
     assert [transaction] = transactions
 
-    assert transaction.transaction == "Elixir.PhoenixAppWeb.PageController#transaction"
-    assert transaction.transaction_info == %{source: "view"}
+    assert transaction.transaction == "test_span"
+    assert transaction.transaction_info == %{source: :custom}
 
     trace = transaction.contexts.trace
-    assert trace.origin == "opentelemetry_phoenix"
-    assert trace.op == "http.server"
-    assert trace.data == %{"http.response.status_code" => 200}
-    assert trace.status == "ok"
-
-    assert transaction.request.env == %{"SERVER_NAME" => "www.example.com", "SERVER_PORT" => 80}
-    assert transaction.request.url == "http://www.example.com/transaction"
-    assert transaction.request.method == "GET"
+    assert trace.origin == "phoenix_app"
+    assert trace.op == "test_span"
+    assert trace.data == %{}
 
     assert [span] = transaction.spans
 
     assert span.op == "test_span"
     assert span.trace_id == trace.trace_id
-    assert span.parent_span_id == trace.span_id
+    refute span.parent_span_id
   end
 
   test "GET /users", %{conn: conn} do
     get(conn, ~p"/users")
 
     transactions = Sentry.Test.pop_sentry_transactions()
 
-    assert length(transactions) == 1
+    assert length(transactions) == 2
 
-    assert [transaction] = transactions
+    assert [mount_transaction, handle_params_transaction] = transactions
 
-    assert transaction.transaction == "Elixir.Phoenix.LiveView.Plug#index"
-    assert transaction.transaction_info == %{source: "view"}
+    assert mount_transaction.transaction == "PhoenixAppWeb.UserLive.Index.mount"
+    assert mount_transaction.transaction_info == %{source: :custom}
 
-    trace = transaction.contexts.trace
+    trace = mount_transaction.contexts.trace
     assert trace.origin == "opentelemetry_phoenix"
-    assert trace.op == "http.server"
-    assert trace.data == %{"http.response.status_code" => 200}
-    assert trace.status == "ok"
-
-    assert transaction.request.env == %{"SERVER_NAME" => "www.example.com", "SERVER_PORT" => 80}
-    assert transaction.request.url == "http://www.example.com/users"
-    assert transaction.request.method == "GET"
+    assert trace.op == "PhoenixAppWeb.UserLive.Index.mount"
+    assert trace.data == %{}
 
-    assert [span_mount, span_handle_params] = transaction.spans
+    assert [span_mount, span_ecto] = mount_transaction.spans
 
-    assert span_mount.op == "http.server.live"
+    assert span_mount.op == "PhoenixAppWeb.UserLive.Index.mount"
     assert span_mount.description == "PhoenixAppWeb.UserLive.Index.mount"
 
-    assert span_handle_params.op == "http.server.live"
+    assert span_ecto.op == "db"
+    assert span_ecto.description == "SELECT u0.\"id\", u0.\"name\", u0.\"age\", u0.\"inserted_at\", u0.\"updated_at\" FROM \"users\" AS u0"
+
+    assert handle_params_transaction.transaction == "PhoenixAppWeb.UserLive.Index.handle_params"
+    assert handle_params_transaction.transaction_info == %{source: :custom}
+
+    trace = handle_params_transaction.contexts.trace
+    assert trace.origin == "opentelemetry_phoenix"
+    assert trace.op == "PhoenixAppWeb.UserLive.Index.handle_params"
+    assert trace.data == %{}
+
+    assert [span_handle_params] = handle_params_transaction.spans
+
+    assert span_handle_params.op == "PhoenixAppWeb.UserLive.Index.handle_params"
     assert span_handle_params.description == "PhoenixAppWeb.UserLive.Index.handle_params"
   end
 end
diff --git a/test_integrations/phoenix_app/test/phoenix_app_web/live/user_live_test.exs b/test_integrations/phoenix_app/test/phoenix_app_web/live/user_live_test.exs
@@ -60,17 +60,17 @@ defmodule PhoenixAppWeb.UserLiveTest do
         end)
 
       assert transaction_save.transaction == "PhoenixAppWeb.UserLive.Index.handle_event#save"
-      assert transaction_save.transaction_info.source == "view"
-      assert transaction_save.contexts.trace.op == "http.server.live"
+      assert transaction_save.transaction_info.source == :custom
+      assert transaction_save.contexts.trace.op == "PhoenixAppWeb.UserLive.Index.handle_event#save"
       assert transaction_save.contexts.trace.origin == "opentelemetry_phoenix"
 
-      assert length(transaction_save.spans) == 1
-      span = List.first(transaction_save.spans)
-      assert span.op == "db.sql.ecto"
-      assert span.description =~ "INSERT INTO \"users\""
-      assert span.data["db.system"] == :sqlite
-      assert span.data["db.type"] == :sql
-      assert span.origin == "opentelemetry_ecto"
+      assert length(transaction_save.spans) == 2
+      assert [_span_1, span_2] = transaction_save.spans
+      assert span_2.op == "db"
+      assert span_2.description =~ "INSERT INTO \"users\""
+      assert span_2.data["db.system"] == :sqlite
+      assert span_2.data["db.type"] == :sql
+      assert span_2.origin == "opentelemetry_ecto"
     end
 
     test "updates user in listing", %{conn: conn, user: user} do

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,8 @@ defmodule Sentry.Mixfile do`
`115`	`115`
`116`	`116`	`# Required by Tracing`
`117`	`117`	`{:opentelemetry, "~> 1.5"},`
`118`		`- {:opentelemetry_api, "~> 1.3"}`
	`118`	`+ {:opentelemetry_api, "~> 1.3"},`
	`119`	`+ {:opentelemetry_semantic_conventions, "~> 1.0"}`
`119`	`120`	`]`
`120`	`121`	`end`
`121`	`122`