Validate options even if DSN is not set (#772)

Author: savhappy

lib/sentry.ex

@@ -335,6 +335,7 @@ defmodule Sentry do
         Client.send_event(event, opts)
 
       !Config.dsn() ->
+        _opts = Client.validate_options!(opts)
         :ignored
 
       included_envs == :all or to_string(Config.environment_name()) in included_envs ->

lib/sentry/client.ex

@@ -116,7 +116,7 @@ defmodule Sentry.Client do
           | :unsampled
           | :excluded
   def send_event(%Event{} = event, opts) when is_list(opts) do
-    opts = NimbleOptions.validate!(opts, @send_event_opts_schema)
+    opts = validate_options!(opts)
 
     result_type = Keyword.get_lazy(opts, :result, &Config.send_result/0)
     sample_rate = Keyword.get_lazy(opts, :sample_rate, &Config.sample_rate/0)
@@ -160,6 +160,11 @@ defmodule Sentry.Client do
     end
   end
 
+  @spec validate_options!(keyword()) :: keyword()
+  def validate_options!(opts) when is_list(opts) do
+    NimbleOptions.validate!(opts, @send_event_opts_schema)
+  end
+
   defp sample_event(sample_rate) do
     cond do
       sample_rate == 1 -> :ok

test/sentry_test.exs

@@ -119,6 +119,16 @@ defmodule SentryTest do
     assert logged_count == 2
   end
 
+  test "raises error with validate_and_ignore/1 in dev mode if opts passed are invalid " do
+    put_test_config(dsn: nil, test_mode: false)
+
+    assert_raise NimbleOptions.ValidationError, fn ->
+      Sentry.Client.validate_options!(client: [bad_key: :nada])
+    end
+
+    assert [client: :hackney] = Sentry.Client.validate_options!(client: :hackney)
+  end
+
   test "does not send events if :dsn is not configured or nil (if not in test mode)" do
     put_test_config(dsn: nil, test_mode: false)
     event = Sentry.Event.transform_exception(%RuntimeError{message: "oops"}, [])