avoid poison raising exception

Author: mitchellhenke

lib/sentry/client.ex

@@ -24,11 +24,15 @@ defmodule Sentry.Client do
     {endpoint, public_key, secret_key} = get_dsn!()
 
     auth_headers = authorization_headers(public_key, secret_key)
-    body = Poison.encode!(event)
-
-    Task.Supervisor.async_nolink(Sentry.TaskSupervisor, fn ->
-      try_request(:post, endpoint, auth_headers, body)
-    end)
+    case Poison.encode(event) do
+      {:ok, body} ->
+        Task.Supervisor.async_nolink(Sentry.TaskSupervisor, fn ->
+          try_request(:post, endpoint, auth_headers, body)
+        end)
+      {:error, error} ->
+        log_api_error("Unable to encode Sentry error - #{inspect(error)}")
+        :error
+    end
   end
 
   defp try_request(method, url, headers, body) do

test/client_test.exs

@@ -48,4 +48,9 @@ defmodule Sentry.ClientTest do
         end) =~ ~r/400.*Creation of this event was denied due to rate limiting/
       end
   end
+
+  test "errors when attempting to report invalid JSON" do
+    unencodable_tuple = {:a, :b, :c}
+    assert :error = Sentry.capture_message(unencodable_tuple)
+  end
 end

test/support/test_client.ex

@@ -1,7 +1,11 @@
 defmodule Sentry.TestClient do
   def send_event(%Sentry.Event{} = event) do
     {endpoint, _public_key, _secret_key} = Sentry.Client.get_dsn!
-    body = Poison.encode!(event)
-    Sentry.Client.request(:post, endpoint, [], body)
+    case Poison.encode(event) do
+      {:ok, body} ->
+        Sentry.Client.request(:post, endpoint, [], body)
+      {:error, _error} ->
+        :error
+    end
   end
 end