more robust phoenix endpoint/router testing

Author: mitchellhenke

test/plug_capture_test.exs

@@ -2,16 +2,31 @@ defmodule Sentry.PlugCaptureTest do
   use ExUnit.Case
   use Plug.Test
   import Sentry.TestEnvironmentHelper
+  import ExUnit.CaptureLog
+
+  defmodule PhoenixController do
+    use Phoenix.Controller
+    def error(_conn, _params), do: raise("PhoenixError")
+  end
+
+  defmodule PhoenixRouter do
+    use Phoenix.Router
+
+    get "/error_route", PhoenixController, :error
+  end
 
   defmodule PhoenixEndpoint do
     use Sentry.PlugCapture
     use Phoenix.Endpoint, otp_app: :sentry
-    plug(:error)
-    plug(Sentry.ExamplePlugApplication)
 
-    def error(_conn, _opts) do
-      raise "EndpointError"
-    end
+    plug Plug.Parsers,
+      parsers: [:urlencoded, :multipart, :json],
+      pass: ["*/*"],
+      json_decoder: Jason
+
+    plug Sentry.PlugContext
+
+    plug PhoenixRouter
   end
 
   test "sends error to Sentry" do
@@ -84,8 +99,8 @@ defmodule Sentry.PlugCaptureTest do
     Bypass.expect(bypass, fn conn ->
       {:ok, body, conn} = Plug.Conn.read_body(conn)
       json = Jason.decode!(body)
-      assert json["culprit"] == "Sentry.PlugCaptureTest.PhoenixEndpoint.error/2"
-      assert json["message"] == "(RuntimeError) EndpointError"
+      assert json["culprit"] == "Sentry.PlugCaptureTest.PhoenixController.error/2"
+      assert json["message"] == "(RuntimeError) PhoenixError"
       Plug.Conn.resp(conn, 200, ~s<{"id": "340"}>)
     end)
 
@@ -96,13 +111,14 @@ defmodule Sentry.PlugCaptureTest do
       ]
     )
 
-    modify_env(:phoenix, format_encoders: [])
     {:ok, _} = PhoenixEndpoint.start_link()
 
-    assert_raise RuntimeError, "EndpointError", fn ->
-      conn(:get, "/")
-      |> PhoenixEndpoint.call([])
-    end
+    capture_log(fn ->
+      assert_raise RuntimeError, "PhoenixError", fn ->
+        conn(:get, "/error_route")
+        |> PhoenixEndpoint.call([])
+      end
+    end)
   end
 
   test "can render feedback form in Phoenix ErrorView" do
@@ -118,17 +134,18 @@ defmodule Sentry.PlugCaptureTest do
       dsn: "http://public:secret@localhost:#{bypass.port}/1",
       "#{__MODULE__.PhoenixEndpoint}": [
         render_errors: [view: Sentry.ErrorView, accepts: ~w(html)]
-      ],
-      phoenix: [format_encoders: []]
+      ]
     )
 
     {:ok, _} = PhoenixEndpoint.start_link()
 
-    conn = conn(:get, "/")
+    conn = conn(:get, "/error_route")
 
-    assert_raise RuntimeError, "EndpointError", fn ->
-      PhoenixEndpoint.call(conn, [])
-    end
+    capture_log(fn ->
+      assert_raise RuntimeError, "PhoenixError", fn ->
+        PhoenixEndpoint.call(conn, [])
+      end
+    end)
 
     {event_id, _} = Sentry.last_event_id_and_source()
 
@@ -139,6 +156,41 @@ defmodule Sentry.PlugCaptureTest do
     assert body =~ ~s{"title":"Testing"}
   end
 
+  test "does not send NoRouteError in Phoenix application" do
+    bypass = Bypass.open()
+
+    Bypass.expect_once(bypass, fn conn ->
+      {:ok, body, conn} = Plug.Conn.read_body(conn)
+      _json = Jason.decode!(body)
+      Plug.Conn.resp(conn, 200, ~s<{"id": "340"}>)
+    end)
+
+    modify_env(:sentry,
+      dsn: "http://public:secret@localhost:#{bypass.port}/1",
+      "#{__MODULE__.PhoenixEndpoint}": [
+        render_errors: [view: Sentry.ErrorView, accepts: ~w(html)]
+      ]
+    )
+
+    {:ok, _} = PhoenixEndpoint.start_link()
+
+    capture_log(fn ->
+      assert_raise RuntimeError, "PhoenixError", fn ->
+        conn(:get, "/error_route")
+        |> PhoenixEndpoint.call([])
+      end
+
+      assert_raise(
+        Phoenix.Router.NoRouteError,
+        "no route found for GET /not_found (Sentry.PlugCaptureTest.PhoenixRouter)",
+        fn ->
+          conn(:get, "/not_found")
+          |> PhoenixEndpoint.call([])
+        end
+      )
+    end)
+  end
+
   test "can render feedback form in Plug application" do
     bypass = Bypass.open()