Add tests for Sentry.send_transaction

Author: solnic

lib/sentry.ex

@@ -362,16 +362,22 @@ defmodule Sentry do
     end
   end
 
-  def send_transaction(transaction, opts \\ []) do
+  def send_transaction(transaction, options \\ []) do
     # TODO: remove on v11.0.0, :included_environments was deprecated in 10.0.0.
     included_envs = Config.included_environments()
 
     cond do
       Config.test_mode?() ->
-        Client.send_transaction(transaction, opts)
+        Client.send_transaction(transaction, options)
+
+      !Config.dsn() ->
+        # We still validate options even if we're not sending the event. This aims at catching
+        # configuration issues during development instead of only when deploying to production.
+        _options = NimbleOptions.validate!(options, Options.send_event_schema())
+        :ignored
 
       included_envs == :all or to_string(Config.environment_name()) in included_envs ->
-        Client.send_transaction(transaction, opts)
+        Client.send_transaction(transaction, options)
 
       true ->
         :ignored

test/sentry_test.exs

@@ -235,4 +235,41 @@ defmodule SentryTest do
       assert Sentry.get_dsn() == random_dsn
     end
   end
+
+  describe "send_transaction/2" do
+    setup do
+      transaction =
+        Sentry.Transaction.new(%{
+          transaction: "test-transaction",
+          start_timestamp: System.system_time(:second),
+          timestamp: System.system_time(:second)
+        })
+
+      {:ok, transaction: transaction}
+    end
+
+    test "sends transaction to Sentry when configured properly", %{
+      bypass: bypass,
+      transaction: transaction
+    } do
+      Bypass.expect_once(bypass, "POST", "/api/1/envelope/", fn conn ->
+        {:ok, body, conn} = Plug.Conn.read_body(conn)
+        assert [{headers, transaction_body}] = decode_envelope!(body)
+
+        assert headers["type"] == "transaction"
+        assert Map.has_key?(headers, "length")
+        assert transaction_body["transaction"] == "test-transaction"
+
+        Plug.Conn.send_resp(conn, 200, ~s<{"id": "340"}>)
+      end)
+
+      assert {:ok, "340"} = Sentry.send_transaction(transaction)
+    end
+
+    test "ignores transaction when dsn is not configured", %{transaction: transaction} do
+      put_test_config(dsn: nil, test_mode: false)
+
+      assert :ignored = Sentry.send_transaction(transaction)
+    end
+  end
 end