Support Transaction in client reports

Author: solnic

lib/sentry/envelope.ex

@@ -63,12 +63,20 @@ defmodule Sentry.Envelope do
   Returns the "data category" of the envelope's contents (to be used in client reports and more).
   """
   @doc since: "10.8.0"
-  @spec get_data_category(Attachment.t() | CheckIn.t() | ClientReport.t() | Event.t()) ::
+  @spec get_data_category(
+          Attachment.t()
+          | CheckIn.t()
+          | ClientReport.t()
+          | Event.t()
+          | Transaction.t()
+        ) ::
           String.t()
   def get_data_category(%Attachment{}), do: "attachment"
   def get_data_category(%CheckIn{}), do: "monitor"
   def get_data_category(%ClientReport{}), do: "internal"
   def get_data_category(%Event{}), do: "error"
+  # TODO: is this correct?
+  def get_data_category(%Transaction{}), do: "error"
 
   @doc """
   Encodes the envelope into its binary representation.

test/sentry/client_report/sender_test.exs

@@ -4,7 +4,7 @@ defmodule Sentry.ClientReportTest do
   import Sentry.TestHelpers
 
   alias Sentry.ClientReport.Sender
-  alias Sentry.Event
+  alias Sentry.{Event, Transaction}
 
   setup do
     original_retries =
@@ -27,24 +27,28 @@ defmodule Sentry.ClientReportTest do
         %Event{
           event_id: Sentry.UUID.uuid4_hex(),
           timestamp: "2024-10-12T13:21:13"
+        },
+        %Transaction{
+          event_id: Sentry.UUID.uuid4_hex(),
+          timestamp: "2024-10-12T13:21:13"
         }
       ]
 
       assert :ok = Sender.record_discarded_events(:before_send, events, :test_client_report)
 
-      assert :sys.get_state(:test_client_report) == %{{:before_send, "error"} => 1}
+      assert :sys.get_state(:test_client_report) == %{{:before_send, "error"} => 2}
 
       assert :ok = Sender.record_discarded_events(:before_send, events, :test_client_report)
 
-      assert :sys.get_state(:test_client_report) == %{{:before_send, "error"} => 2}
+      assert :sys.get_state(:test_client_report) == %{{:before_send, "error"} => 4}
 
       assert :ok = Sender.record_discarded_events(:event_processor, events, :test_client_report)
       assert :ok = Sender.record_discarded_events(:network_error, events, :test_client_report)
 
       assert :sys.get_state(:test_client_report) == %{
-               {:before_send, "error"} => 2,
-               {:event_processor, "error"} => 1,
-               {:network_error, "error"} => 1
+               {:before_send, "error"} => 4,
+               {:event_processor, "error"} => 2,
+               {:network_error, "error"} => 2
              }
 
       send(Process.whereis(:test_client_report), :send_report)
@@ -56,9 +60,9 @@ defmodule Sentry.ClientReportTest do
                  decode_envelope!(body)
 
         assert client_report["discarded_events"] == [
-                 %{"reason" => "before_send", "category" => "error", "quantity" => 2},
-                 %{"reason" => "event_processor", "category" => "error", "quantity" => 1},
-                 %{"reason" => "network_error", "category" => "error", "quantity" => 1}
+                 %{"reason" => "before_send", "category" => "error", "quantity" => 4},
+                 %{"reason" => "event_processor", "category" => "error", "quantity" => 2},
+                 %{"reason" => "network_error", "category" => "error", "quantity" => 2}
                ]
 
         assert client_report["timestamp"] =~ ~r/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}$/