Refine how we set values for Oban jobs

- Use the worker name as the description and transaction name instead of "{worker} process"
- Use "queue.process" as the op - this is according to the docs https://develop.sentry.dev/sdk/telemetry/traces/modules/queues/

Maybe this could be improved in the opentelemetry_oban package?

Author: solnic

lib/sentry/opentelemetry/span_processor.ex

@@ -5,7 +5,7 @@ defmodule Sentry.OpenTelemetry.SpanProcessor do
   require OpenTelemetry.SemConv.Incubating.DBAttributes, as: DBAttributes
   require OpenTelemetry.SemConv.Incubating.HTTPAttributes, as: HTTPAttributes
   require OpenTelemetry.SemConv.Incubating.URLAttributes, as: URLAttributes
-
+  require OpenTelemetry.SemConv.Incubating.MessagingAttributes, as: MessagingAttributes
   @behaviour :otel_span_processor
 
   require Logger
@@ -64,7 +64,7 @@ defmodule Sentry.OpenTelemetry.SpanProcessor do
 
     Transaction.new(%{
       span_id: root_span.span_id,
-      transaction: root_span_record.name,
+      transaction: transaction_name(root_span_record),
       transaction_info: %{source: :custom},
       contexts: %{
         trace: build_trace_context(root_span_record),
@@ -74,6 +74,15 @@ defmodule Sentry.OpenTelemetry.SpanProcessor do
     })
   end
 
+  defp transaction_name(
+         %{attributes: %{unquote(to_string(MessagingAttributes.messaging_system())) => :oban}} =
+           span_record
+       ) do
+    span_record.attributes["oban.job.worker"]
+  end
+
+  defp transaction_name(span_record), do: span_record.name
+
   defp build_trace_context(span_record) do
     {op, description} = get_op_description(span_record)
 
@@ -118,6 +127,13 @@ defmodule Sentry.OpenTelemetry.SpanProcessor do
     {"db", db_query_text}
   end
 
+  defp get_op_description(%{
+         attributes:
+           %{unquote(to_string(MessagingAttributes.messaging_system())) => :oban} = attributes
+       }) do
+    {"queue.process", attributes["oban.job.worker"]}
+  end
+
   defp get_op_description(span_record) do
     {span_record.name, span_record.name}
   end

test_integrations/phoenix_app/test/phoenix_app/oban_test.exs

@@ -28,16 +28,23 @@ defmodule Sentry.Integrations.Phoenix.ObanTest do
 
     [transaction] = transactions
 
-    assert transaction.transaction == "Sentry.Integrations.Phoenix.ObanTest.TestWorker process"
+    assert transaction.transaction == "Sentry.Integrations.Phoenix.ObanTest.TestWorker"
     assert transaction.transaction_info == %{source: :custom}
 
     trace = transaction.contexts.trace
     assert trace.origin == "opentelemetry_oban"
-    assert trace.op == "Sentry.Integrations.Phoenix.ObanTest.TestWorker process"
+    assert trace.op == "queue.process"
+    assert trace.description == "Sentry.Integrations.Phoenix.ObanTest.TestWorker"
     assert trace.data["oban.job.job_id"]
     assert trace.data["messaging.destination"] == "default"
     assert trace.data["oban.job.attempt"] == 1
 
-    assert [_span] = transaction.spans
+    assert [span] = transaction.spans
+
+    assert span.op == "queue.process"
+    assert span.description == "Sentry.Integrations.Phoenix.ObanTest.TestWorker"
+    assert span.data["oban.job.job_id"]
+    assert span.data["messaging.destination"] == "default"
+    assert span.data["oban.job.attempt"] == 1
   end
 end