Refactor get_parent_sampling_decision to remove unnecessary try/rescue and simplify logic

Author: solnic

lib/sentry/opentelemetry/sampler.ex

@@ -45,29 +45,25 @@ if Code.ensure_loaded?(:otel_sampler) do
     end
 
     defp get_parent_sampling_decision(ctx, trace_id) do
-      try do
-        case :otel_tracer.current_span_ctx(ctx) do
-          :undefined ->
-            :no_parent
+      case :otel_tracer.current_span_ctx(ctx) do
+        :undefined ->
+          :no_parent
 
-          span_ctx ->
-            parent_trace_id = :otel_span.trace_id(span_ctx)
+        span_ctx ->
+          parent_trace_id = :otel_span.trace_id(span_ctx)
 
-            if parent_trace_id == trace_id do
-              tracestate = :otel_span.tracestate(span_ctx)
-              parent_sampled = get_tracestate_value(tracestate, @sentry_sampled_key)
+          if parent_trace_id == trace_id do
+            tracestate = :otel_span.tracestate(span_ctx)
+            parent_sampled = get_tracestate_value(tracestate, @sentry_sampled_key)
 
-              case parent_sampled do
-                "true" -> {:inherit, true, tracestate}
-                "false" -> {:inherit, false, tracestate}
-                _ -> :no_parent
-              end
-            else
-              :no_parent
+            case parent_sampled do
+              "true" -> {:inherit, true, tracestate}
+              "false" -> {:inherit, false, tracestate}
+              _ -> :no_parent
             end
-        end
-      rescue
-        _ -> :no_parent
+          else
+            :no_parent
+          end
       end
     end