put args in stacktrace frames

Author: mitchellhenke

lib/sentry/event.ex

@@ -89,7 +89,6 @@ defmodule Sentry.Event do
     server_name = Config.server_name()
 
     env = Config.environment_name()
-    f_args = args_from_stacktrace(stacktrace)
 
     %Event{
       culprit: culprit_from_stacktrace(stacktrace),
@@ -101,7 +100,6 @@ defmodule Sentry.Event do
       exception: exception,
       stacktrace: %{
         frames: stacktrace_to_frames(stacktrace),
-        vars: f_args,
       },
       release: release,
       extra: extra,
@@ -173,6 +171,7 @@ defmodule Sentry.Event do
     stacktrace
     |> Enum.map(fn(line) ->
         {mod, function, arity_or_args, location} = line
+        f_args = args_from_stacktrace([line])
         arity = arity_to_integer(arity_or_args)
         file = Keyword.get(location, :file)
         file = if(file, do: String.Chars.to_string(file), else: file)
@@ -184,6 +183,7 @@ defmodule Sentry.Event do
           module: mod,
           lineno: line_number,
           in_app: is_in_app?(mod, in_app_module_whitelist),
+          vars: f_args,
         }
         |> put_source_context(file, line_number)
       end)

test/event_test.exs

@@ -25,14 +25,14 @@ defmodule Sentry.EventTest do
     assert event.level == "error"
     assert event.message == "(UndefinedFunctionError) function Sentry.Event.not_a_function/3 is undefined or private"
     assert is_binary(event.server_name)
-    assert event.stacktrace == %{vars: %{"arg0" => "1", "arg1" => "2", "arg2" => "3"},
+    assert event.stacktrace == %{
       frames: Enum.reverse([
-        %{filename: nil, function: "Sentry.Event.not_a_function/3", lineno: nil, module: Sentry.Event, context_line: nil, post_context: [], pre_context: [], in_app: false},
-        %{filename: "test/event_test.exs", function: "Sentry.EventTest.event_generated_by_exception/1", lineno: 8, module: Sentry.EventTest, context_line: nil, post_context: [], pre_context: [], in_app: false},
-        %{filename: "test/event_test.exs", function: "Sentry.EventTest.\"test parses error exception\"/1", lineno: 15, module: Sentry.EventTest, context_line: nil, post_context: [], pre_context: [], in_app: false},
-        %{filename: "lib/ex_unit/runner.ex", function: "ExUnit.Runner.exec_test/1", lineno: 302, module: ExUnit.Runner, context_line: nil, post_context: [], pre_context: [], in_app: false},
-        %{filename: "timer.erl", function: ":timer.tc/1", lineno: 166, module: :timer, context_line: nil, post_context: [], pre_context: [], in_app: false},
-        %{filename: "lib/ex_unit/runner.ex", function: "anonymous fn/3 in ExUnit.Runner.spawn_test/3", lineno: 250, module: ExUnit.Runner, context_line: nil, post_context: [], pre_context: [], in_app: false}])
+        %{filename: nil, function: "Sentry.Event.not_a_function/3", lineno: nil, module: Sentry.Event, context_line: nil, post_context: [], pre_context: [], in_app: false, vars: %{"arg0" => "1", "arg1" => "2", "arg2" => "3"}},
+        %{filename: "test/event_test.exs", function: "Sentry.EventTest.event_generated_by_exception/1", lineno: 8, module: Sentry.EventTest, context_line: nil, post_context: [], pre_context: [], in_app: false, vars: %{}},
+        %{filename: "test/event_test.exs", function: "Sentry.EventTest.\"test parses error exception\"/1", lineno: 15, module: Sentry.EventTest, context_line: nil, post_context: [], pre_context: [], in_app: false, vars: %{}},
+        %{filename: "lib/ex_unit/runner.ex", function: "ExUnit.Runner.exec_test/1", lineno: 302, module: ExUnit.Runner, context_line: nil, post_context: [], pre_context: [], in_app: false, vars: %{}},
+        %{filename: "timer.erl", function: ":timer.tc/1", lineno: 166, module: :timer, context_line: nil, post_context: [], pre_context: [], in_app: false, vars: %{}},
+        %{filename: "lib/ex_unit/runner.ex", function: "anonymous fn/3 in ExUnit.Runner.spawn_test/3", lineno: 250, module: ExUnit.Runner, context_line: nil, post_context: [], pre_context: [], in_app: false, vars: %{}}])
     }
     assert event.tags == %{}
     assert event.timestamp =~ ~r/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/
@@ -85,35 +85,38 @@ defmodule Sentry.EventTest do
                                                                       {:other_module, :a_method, 8, []}, {:random, :uniform, 0, []},
                                                                       {Sentry.Submodule.Fun, :this_method, 0, []}]])
     assert %{
-      vars: %{},
       frames: [
         %{
           module: Sentry.Submodule.Fun,
           function: "Sentry.Submodule.Fun.this_method/0",
           in_app: true,
           filename: nil, lineno: nil,
-          context_line: nil, post_context: [], pre_context: []
+          context_line: nil, post_context: [], pre_context: [],
+          vars: %{},
         },
         %{
           module: :random,
           function: ":random.uniform/0",
           in_app: true,
           filename: nil, lineno: nil,
-          context_line: nil, post_context: [], pre_context: []
+          context_line: nil, post_context: [], pre_context: [],
+          vars: %{},
         },
         %{
           module: :other_module,
           function: ":other_module.a_method/8",
           in_app: false,
           filename: nil, lineno: nil,
-          context_line: nil, post_context: [], pre_context: []
+          context_line: nil, post_context: [], pre_context: [],
+          vars: %{},
         },
         %{
           module: Sentry,
           function: "Sentry.other_method/4",
           in_app: true,
           filename: nil, lineno: nil,
-          context_line: nil, post_context: [], pre_context: []
+          context_line: nil, post_context: [], pre_context: [],
+          vars: %{},
         },
         %{
           filename: nil,
@@ -123,7 +126,8 @@ defmodule Sentry.EventTest do
           in_app: true,
           context_line: nil,
           post_context: [],
-          pre_context: []
+          pre_context: [],
+          vars: %{},
         },
       ]} == event.stacktrace
   end

test/logger_test.exs

@@ -94,6 +94,7 @@ defmodule Sentry.LoggerTest do
                                                           "context_line" => nil,
                                                           "pre_context" => [],
                                                           "post_context" => [],
+                                                          "vars" => %{"arg0" => "{}", "arg1" => "{0, 0}"}
                                                         }
       assert conn.request_path == "/api/1/store/"
       assert conn.method == "POST"