fix test with vocab change and keep hackney options

Author: savhappy

lib/sentry/config.ex

@@ -316,6 +316,35 @@ defmodule Sentry.Config do
       `Sentry.FinchClient`.
       """
     ]
+    # hackney_opts: [
+    #   type: :keyword_list,
+    #   deprecated: "Use Finch instead as default client.",
+    #   default: [pool: :sentry_pool],
+    #   doc: """
+    #   Options to be passed to `hackney`. Only
+    #   applied if `:client` is set to `Sentry.HackneyClient`.
+    #   """
+    # ],
+    # hackney_pool_timeout: [
+    #   type: :timeout,
+    #   deprecated: "Use Finch instead as default client.",
+    #   default: 5000,
+    #   doc: """
+    #   The maximum time to wait for a
+    #   connection to become available. Only applied if `:client` is set to
+    #   `Sentry.HackneyClient`.
+    #   """
+    # ],
+    # hackney_pool_max_connections: [
+    #   type: :pos_integer,
+    #   deprecated: "Use Finch instead as default client.",
+    #   default: 50,
+    #   doc: """
+    #   The maximum number of
+    #   connections to keep in the pool. Only applied if `:client` is set to
+    #   `Sentry.HackneyClient`.
+    #   """
+    # ]
   ]
 
   source_code_context_opts_schema = [

lib/sentry/finch_client.ex

@@ -11,9 +11,9 @@ defmodule Sentry.FinchClient do
   HTTP client, you'll have to implement your own `Sentry.HTTPClient`. See the
   documentation for `Sentry.HTTPClient` for more information.
 
-  Finch is built on top of NimblePool. If you need to set other pool configuration options,
-  see "Pool Configuration Options" in the source code for details on the possible map values.
-  [finch configuration options](https://github.com/sneako/finch/blob/main/lib/finch.ex)
+  Finch is built on top of [NimblePool](https://github.com/dashbitco/nimble_pool). If you need to set other pool configuration options,
+  see "Pool Configuration Options" in the Finch documentation for details on the possible map values.
+  [finch configuration options](https://hexdocs.pm/finch/Finch.html#start_link/1-pool-configuration-options)
   """
   @impl true
   def child_spec do

mix.exs

@@ -94,7 +94,7 @@ defmodule Sentry.Mixfile do
       {:nimble_ownership, "~> 0.3.0 or ~> 1.0"},
 
       # Optional dependencies
-      {:finch, "~> 0.18.0", optional: true},
+      {:finch, "~> 0.19.0", optional: true},
       {:jason, "~> 1.1", optional: true},
       {:phoenix, "~> 1.6", optional: true},
       {:phoenix_live_view, "~> 0.20 or ~> 1.0", optional: true},

mix.lock

@@ -15,7 +15,7 @@ defmodule Mix.Tasks.Sentry.SendTestEventTest do
     assert output =~ """
            Client configuration:
            current environment_name: "some_env"
-           finch_opts: []
+           Finch options: []
            """
 
     assert output =~ ~s(Event not sent because the :dsn option is not set)
@@ -49,7 +49,7 @@ defmodule Mix.Tasks.Sentry.SendTestEventTest do
            public_key: public
            secret_key: secret
            current environment_name: "test"
-           finch_opts: []
+           Finch options: []
            """
 
     assert output =~ "Sending test event..."

test/mix/sentry.send_test_event_test.exs

@@ -658,7 +658,7 @@ defmodule Sentry.LoggerHandlerTest do
     put_test_config(
       dsn: "http://public:secret@localhost:#{bypass.port}/1",
       dedup_events: false,
-      hackney_opts: [recv_timeout: 500, pool: :sentry_pool]
+      finch_opts: []
     )
 
     Bypass.expect(bypass, fn conn ->

test/sentry/logger_handler_test.exs

@@ -246,12 +246,12 @@ defmodule Sentry.TransportTest do
 
       assert :too_many_retries =
                error(fn ->
-                 Transport.encode_and_post_envelope(envelope, HackneyClient, _retries = [])
+                 Transport.encode_and_post_envelope(envelope, FinchClient, _retries = [])
                end)
 
       log =
         capture_log(fn ->
-          Transport.encode_and_post_envelope(envelope, HackneyClient, _retries = [])
+          Transport.encode_and_post_envelope(envelope, FinchClient, _retries = [])
         end)
 
       assert log =~ "[warning]"