Support for liveview traces/spans

Author: solnic

lib/sentry/opentelemetry/span_processor.ex

@@ -67,7 +67,8 @@ defmodule Sentry.Opentelemetry.SpanProcessor do
   defp build_transaction(
          %SpanRecord{attributes: attributes, origin: "opentelemetry_phoenix"} = root_span,
          child_spans
-       ) do
+       )
+       when map_size(attributes) > 0 do
     Transaction.new(%{
       transaction: "#{attributes["phoenix.plug"]}##{attributes["phoenix.action"]}",
       start_timestamp: root_span.start_time,
@@ -103,6 +104,25 @@ defmodule Sentry.Opentelemetry.SpanProcessor do
     })
   end
 
+  defp build_transaction(
+         %SpanRecord{attributes: attributes, origin: "opentelemetry_phoenix"} = root_span,
+         child_spans
+       )
+       when map_size(attributes) == 0 do
+    Transaction.new(%{
+      transaction: root_span.name,
+      start_timestamp: root_span.start_time,
+      timestamp: root_span.end_time,
+      transaction_info: %{
+        source: "view"
+      },
+      contexts: %{
+        trace: build_trace_context(root_span)
+      },
+      spans: Enum.map(child_spans, &build_span(&1))
+    })
+  end
+
   defp build_transaction(
          %SpanRecord{attributes: attributes, origin: "opentelemetry_bandit"} = root_span,
          child_spans
@@ -135,7 +155,8 @@ defmodule Sentry.Opentelemetry.SpanProcessor do
 
   defp build_trace_context(
          %SpanRecord{origin: "opentelemetry_phoenix", attributes: attributes} = root_span
-       ) do
+       )
+       when map_size(attributes) > 0 do
     %{
       trace_id: root_span.trace_id,
       span_id: root_span.span_id,
@@ -149,6 +170,20 @@ defmodule Sentry.Opentelemetry.SpanProcessor do
     }
   end
 
+  defp build_trace_context(
+         %SpanRecord{origin: "opentelemetry_phoenix", attributes: attributes} = root_span
+       )
+       when map_size(attributes) == 0 do
+    %{
+      trace_id: root_span.trace_id,
+      span_id: root_span.span_id,
+      parent_span_id: nil,
+      op: "http.server.live",
+      description: root_span.name,
+      origin: root_span.origin
+    }
+  end
+
   defp build_trace_context(
          %SpanRecord{origin: "opentelemetry_ecto", attributes: attributes} = root_span
        ) do
@@ -174,6 +209,22 @@ defmodule Sentry.Opentelemetry.SpanProcessor do
     }
   end
 
+  defp build_span(
+         %SpanRecord{origin: "opentelemetry_phoenix", attributes: attributes} = span_record
+       )
+       when map_size(attributes) == 0 do
+    %Span{
+      op: "http.server.live",
+      description: span_record.name,
+      start_timestamp: span_record.start_time,
+      timestamp: span_record.end_time,
+      trace_id: span_record.trace_id,
+      span_id: span_record.span_id,
+      parent_span_id: span_record.parent_span_id,
+      origin: span_record.origin
+    }
+  end
+
   defp build_span(
          %SpanRecord{origin: "opentelemetry_phoenix", attributes: attributes} = span_record
        ) do

test_integrations/phoenix_app/config/test.exs

@@ -3,6 +3,7 @@ import Config
 # Configure your database
 config :phoenix_app, PhoenixApp.Repo,
   adapter: Ecto.Adapters.SQLite3,
+  pool: Ecto.Adapters.SQL.Sandbox,
   database: "db/test.sqlite3"
 
 # We don't run a server during test. If one is required,

test_integrations/phoenix_app/db/dev.sqlite3

@@ -0,0 +1,104 @@
+defmodule PhoenixApp.Accounts do
+  @moduledoc """
+  The Accounts context.
+  """
+
+  import Ecto.Query, warn: false
+  alias PhoenixApp.Repo
+
+  alias PhoenixApp.Accounts.User
+
+  @doc """
+  Returns the list of users.
+
+  ## Examples
+
+      iex> list_users()
+      [%User{}, ...]
+
+  """
+  def list_users do
+    Repo.all(User)
+  end
+
+  @doc """
+  Gets a single user.
+
+  Raises `Ecto.NoResultsError` if the User does not exist.
+
+  ## Examples
+
+      iex> get_user!(123)
+      %User{}
+
+      iex> get_user!(456)
+      ** (Ecto.NoResultsError)
+
+  """
+  def get_user!(id), do: Repo.get!(User, id)
+
+  @doc """
+  Creates a user.
+
+  ## Examples
+
+      iex> create_user(%{field: value})
+      {:ok, %User{}}
+
+      iex> create_user(%{field: bad_value})
+      {:error, %Ecto.Changeset{}}
+
+  """
+  def create_user(attrs \\ %{}) do
+    %User{}
+    |> User.changeset(attrs)
+    |> Repo.insert()
+  end
+
+  @doc """
+  Updates a user.
+
+  ## Examples
+
+      iex> update_user(user, %{field: new_value})
+      {:ok, %User{}}
+
+      iex> update_user(user, %{field: bad_value})
+      {:error, %Ecto.Changeset{}}
+
+  """
+  def update_user(%User{} = user, attrs) do
+    user
+    |> User.changeset(attrs)
+    |> Repo.update()
+  end
+
+  @doc """
+  Deletes a user.
+
+  ## Examples
+
+      iex> delete_user(user)
+      {:ok, %User{}}
+
+      iex> delete_user(user)
+      {:error, %Ecto.Changeset{}}
+
+  """
+  def delete_user(%User{} = user) do
+    Repo.delete(user)
+  end
+
+  @doc """
+  Returns an `%Ecto.Changeset{}` for tracking user changes.
+
+  ## Examples
+
+      iex> change_user(user)
+      %Ecto.Changeset{data: %User{}}
+
+  """
+  def change_user(%User{} = user, attrs \\ %{}) do
+    User.changeset(user, attrs)
+  end
+end

test_integrations/phoenix_app/db/dev.sqlite3-shm

@@ -0,0 +1,18 @@
+defmodule PhoenixApp.Accounts.User do
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  schema "users" do
+    field :name, :string
+    field :age, :integer
+
+    timestamps(type: :utc_datetime)
+  end
+
+  @doc false
+  def changeset(user, attrs) do
+    user
+    |> cast(attrs, [:name, :age])
+    |> validate_required([:name, :age])
+  end
+end