Merge pull request #344 from heymackey/fix-unmatched-return-in-phoenix-endpoint

Fixes dialyzer warning when using the Sentry.Phoenix.Endpoint macro

Author: mitchellhenke

lib/sentry/phoenix_endpoint.ex

@@ -36,13 +36,14 @@ defmodule Sentry.Phoenix.Endpoint do
             request = Sentry.Plug.build_request_interface_data(conn, [])
             exception = Exception.normalize(kind, reason, stacktrace)
 
-            Sentry.capture_exception(
-              exception,
-              stacktrace: stacktrace,
-              request: request,
-              event_source: :endpoint,
-              error_type: kind
-            )
+            _ =
+              Sentry.capture_exception(
+                exception,
+                stacktrace: stacktrace,
+                request: request,
+                event_source: :endpoint,
+                error_type: kind
+              )
 
             :erlang.raise(kind, reason, stacktrace)
         end

lib/sentry/plug.ex

@@ -171,24 +171,14 @@ if Code.ensure_loaded?(Plug) do
         headers: handle_data(conn, header_scrubber),
         env: %{
           "REMOTE_ADDR" => remote_address(conn.remote_ip),
-          "REMOTE_PORT" => remote_port(conn),
+          "REMOTE_PORT" => Plug.Conn.get_peer_data(conn).port,
           "SERVER_NAME" => conn.host,
           "SERVER_PORT" => conn.port,
           "REQUEST_ID" => Plug.Conn.get_resp_header(conn, request_id) |> List.first()
         }
       }
     end
 
-    defp remote_port(conn) do
-      case Plug.Conn.get_peer_data(conn) do
-        %{port: port} ->
-          port
-
-        _ ->
-          ""
-      end
-    end
-
     defp remote_address(address) do
       address
       |> :inet.ntoa()