Merge pull request #251 from getsentry/report-spawned-errors

report spawned errors

Author: mitchellhenke

lib/sentry/logger.ex

@@ -47,6 +47,23 @@ defmodule Sentry.Logger do
     {:ok, state}
   end
 
+  def handle_event({:error, _gl, {_pid, _type, [pid, {exception, stack}]} = info}, state)
+      when is_list(stack) and is_pid(pid) do
+    try do
+      opts =
+        Keyword.put([], :event_source, :logger)
+        |> Keyword.put(:stacktrace, stack)
+        |> Keyword.put(:error_type, :error)
+
+      Sentry.capture_exception(exception, opts)
+    rescue
+      ex ->
+        Logger.warn(fn -> "Unable to notify Sentry due to #{inspect(ex)}! #{inspect(info)}" end)
+    end
+
+    {:ok, state}
+  end
+
   def handle_event({:error_report, _gl, {_pid, _type, [message | _]}}, state)
       when is_list(message) do
     try do

test/logger_test.exs

@@ -206,4 +206,29 @@ defmodule Sentry.LoggerTest do
 
     :error_logger.delete_report_handler(Sentry.Logger)
   end
+
+  test "captures errors from spawn() in Plug app" do
+    bypass = Bypass.open()
+    pid = self()
+
+    Bypass.expect(bypass, fn conn ->
+      {:ok, body, conn} = Plug.Conn.read_body(conn)
+      json = Poison.decode!(body)
+      assert length(json["stacktrace"]["frames"]) == 1
+      assert List.first(json["stacktrace"]["frames"])["filename"] == "test/support/test_plug.ex"
+      send(pid, "API called")
+      Plug.Conn.resp(conn, 200, ~s<{"id": "340"}>)
+    end)
+
+    modify_env(:sentry, dsn: "http://public:secret@localhost:#{bypass.port}/1")
+    :error_logger.add_report_handler(Sentry.Logger)
+
+    capture_log(fn ->
+      Plug.Test.conn(:get, "/spawn_error_route")
+      |> Sentry.ExampleApp.call([])
+
+      assert_receive "API called"
+      :error_logger.delete_report_handler(Sentry.Logger)
+    end)
+  end
 end

test/support/test_plug.ex

@@ -19,6 +19,14 @@ defmodule Sentry.ExampleApp do
     raise RuntimeError, "Error"
   end
 
+  get "/spawn_error_route" do
+    spawn(fn ->
+      raise "Error"
+    end)
+
+    send_resp(conn, 200, "")
+  end
+
   match "/error_route" do
     _ = conn
     raise RuntimeError, "Error"