add finch to config.ex

Author: savhappy

lib/sentry/config.ex

@@ -352,11 +352,11 @@ defmodule Sentry.Config do
     client: [
       type: :atom,
       type_doc: "`t:module/0`",
-      default: Sentry.HackneyClient,
+      default: Sentry.FinchClient,
       doc: """
       A module that implements the `Sentry.HTTPClient`
-      behaviour. Defaults to `Sentry.HackneyClient`, which uses
-      [hackney](https://github.com/benoitc/hackney) as the HTTP client.
+      behaviour. Defaults to `Sentry.FinchClient`, which uses
+      [Finch](https://github.com/sneako/finch) as the HTTP client.
       """
     ],
     send_max_attempts: [
@@ -366,6 +366,16 @@ defmodule Sentry.Config do
       The maximum number of attempts to send an event to Sentry.
       """
     ],
+    finch_opts: [
+      type: :keyword_list,
+      default: [size: 50, conn_max_idle_time: 5000],
+      doc: """
+      Pool options to be passed to `Finch.start_link/1`. These options control
+      the connection pool behavior. Only applied if `:client` is set to
+      `Sentry.FinchClient`. See [Finch documentation](https://hexdocs.pm/finch/Finch.html#start_link/1)
+      for available options.
+      """
+    ],
     hackney_opts: [
       type: :keyword_list,
       default: [pool: :sentry_pool],
@@ -663,6 +673,9 @@ defmodule Sentry.Config do
   @spec traces_sampler() :: traces_sampler_function() | nil
   def traces_sampler, do: get(:traces_sampler)
 
+  @spec finch_opts() :: keyword()
+  def finch_opts, do: fetch!(:finch_opts)
+
   @spec hackney_opts() :: keyword()
   def hackney_opts, do: fetch!(:hackney_opts)
 

lib/sentry/finch_client.ex

@@ -23,10 +23,7 @@ defmodule Sentry.FinchClient do
       Finch.child_spec(
         name: __MODULE__,
         pools: %{
-          :default => [
-            size: Sentry.Config.max_finch_connections(),
-            conn_max_idle_time: Sentry.Config.finch_timeout()
-          ]
+          :default => Sentry.Config.finch_opts()
         }
       )
     else

lib/sentry/http_client.ex

@@ -2,7 +2,7 @@ defmodule Sentry.HTTPClient do
   @moduledoc """
   A behaviour for HTTP clients that Sentry can use.
 
-  The default HTTP client is `Sentry.HackneyClient`.
+  The default HTTP client is `Sentry.FinchClient`.
 
   To configure a different HTTP client, implement the `Sentry.HTTPClient` behaviour and
   change the `:client` configuration: