Simplify client reports for dropped transactions

Author: solnic

lib/sentry/client_report/sender.ex

@@ -17,14 +17,21 @@ defmodule Sentry.ClientReport.Sender do
     GenServer.start_link(__MODULE__, nil, name: Keyword.get(opts, :name, __MODULE__))
   end
 
+  def record_discarded_events(reason, info, genserver \\ __MODULE__)
+
+  @spec record_discarded_events(atom(), String.t(), GenServer.server()) :: :ok
+  def record_discarded_events(reason, data_category, genserver)
+      when is_binary(data_category) do
+    GenServer.cast(genserver, {:record_discarded_events, reason, data_category})
+  end
+
   @spec record_discarded_events(atom(), [item], GenServer.server()) :: :ok
         when item:
                Sentry.Attachment.t()
                | Sentry.CheckIn.t()
                | ClientReport.t()
                | Sentry.Event.t()
-               | Sentry.Transaction.t()
-  def record_discarded_events(reason, event_items, genserver \\ __MODULE__)
+  def record_discarded_events(reason, event_items, genserver)
       when is_list(event_items) do
     # We silently ignore events whose reasons aren't valid because we have to add it to the allowlist in Snuba
     # https://develop.sentry.dev/sdk/client-reports/

lib/sentry/opentelemetry/sampler.ex

@@ -3,7 +3,7 @@ if Code.ensure_loaded?(:otel_sampler) do
     @moduledoc false
 
     alias OpenTelemetry.{Span, Tracer}
-    alias Sentry.{ClientReport, Transaction}
+    alias Sentry.ClientReport
 
     @behaviour :otel_sampler
 
@@ -50,7 +50,7 @@ if Code.ensure_loaded?(:otel_sampler) do
 
       case result do
         {:drop, _, _} ->
-          record_discarded_transaction(ctx)
+          record_discarded_transaction()
           result
 
         _ ->
@@ -119,21 +119,8 @@ if Code.ensure_loaded?(:otel_sampler) do
       end
     end
 
-    defp record_discarded_transaction(ctx) do
-      span_id =
-        case Tracer.current_span_ctx(ctx) do
-          :undefined -> Sentry.UUID.uuid4_hex()
-          span_ctx -> Span.span_id(span_ctx)
-        end
-
-      transaction =
-        Transaction.new(%{
-          span_id: span_id,
-          start_timestamp: System.system_time(:second),
-          timestamp: System.system_time(:second)
-        })
-
-      ClientReport.Sender.record_discarded_events(:sample_rate, [transaction])
+    defp record_discarded_transaction() do
+      ClientReport.Sender.record_discarded_events(:sample_rate, "transaction")
     end
   end
 end