Skip to content

Commit 9d6c8f4

Browse files
authored
Update contrib.admin.models.LogEntryManager (typeddjango#2423)
* Update django.contrib.admin.models.LogEntryManager Signed-off-by: SaJH <[email protected]> * Add overload decorator for log_actions to clarify return types Signed-off-by: SaJH <[email protected]> --------- Signed-off-by: SaJH <[email protected]>
1 parent ea16b44 commit 9d6c8f4

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

django-stubs/contrib/admin/models.pyi

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
from typing import Any, ClassVar
1+
from typing import Any, ClassVar, Literal, overload
22
from uuid import UUID
33

44
from django.db import models
5+
from django.db.models import QuerySet
56
from django.db.models.base import Model
67
from typing_extensions import deprecated
78

@@ -21,6 +22,26 @@ class LogEntryManager(models.Manager[LogEntry]):
2122
action_flag: int,
2223
change_message: Any = ...,
2324
) -> LogEntry: ...
25+
@overload
26+
def log_actions(
27+
self,
28+
user_id: int,
29+
queryset: QuerySet[Model],
30+
action_flag: int,
31+
change_message: str | list[Any] = "",
32+
*,
33+
single_object: Literal[True],
34+
) -> LogEntry: ...
35+
@overload
36+
def log_actions(
37+
self,
38+
user_id: int,
39+
queryset: QuerySet[Model],
40+
action_flag: int,
41+
change_message: str | list[Any] = "",
42+
*,
43+
single_object: Literal[False] = False,
44+
) -> list[LogEntry]: ...
2445

2546
class LogEntry(models.Model):
2647
action_time: models.DateTimeField

scripts/stubtest/allowlist_todo_django51.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
django.contrib.admin.helpers.Fieldset.is_collapsible
77
django.contrib.admin.helpers.InlineAdminFormSet.is_collapsible
8-
django.contrib.admin.models.LogEntryManager.log_actions
98
django.contrib.auth.base_user.BaseUserManager.make_random_password
109
django.contrib.auth.checks.check_middleware
1110
django.contrib.auth.forms.AdminPasswordChangeForm.clean_password2

0 commit comments

Comments
 (0)