cherry-pick django 5.1 fixes (#25)

* add cache_name for django 5.1 (typeddjango#2365)

* 5.1: Deprecate CheckConstraint.check (typeddjango#2331)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Co-authored-by: Anthony Sottile <[email protected]>
Co-authored-by: q0w <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 4 people

django-stubs/contrib/contenttypes/fields.pyi

@@ -42,7 +42,6 @@ class GenericForeignKey(FieldCacheMixin):
     def get_filter_kwargs_for_object(self, obj: Model) -> dict[str, ContentType | None]: ...
     def get_forward_related_filter(self, obj: Model) -> dict[str, int]: ...
     def check(self, **kwargs: Any) -> list[CheckMessage]: ...
-    def get_cache_name(self) -> str: ...
     def get_content_type(
         self, obj: Model | None = ..., id: int | None = ..., using: str | None = ..., model: type[Model] | None = ...
     ) -> ContentType: ...

django-stubs/db/models/constraints.pyi

@@ -40,13 +40,26 @@ class BaseConstraint:
 
 class CheckConstraint(BaseConstraint):
     check: Q | BaseExpression
+    condition: Q | BaseExpression
+
+    @overload
+    @deprecated("The check keyword argument is deprecated in favor of condition and will be removed in Django 6.0")
     def __init__(
         self,
         *,
+        name: str,
         check: Q | BaseExpression,
+        violation_error_code: str | None = None,
+        violation_error_message: _StrOrPromise | None = None,
+    ) -> None: ...
+    @overload
+    def __init__(
+        self,
+        *,
         name: str,
-        violation_error_code: str | None = ...,
-        violation_error_message: _StrOrPromise | None = ...,
+        condition: Q | BaseExpression,
+        violation_error_code: str | None = None,
+        violation_error_message: _StrOrPromise | None = None,
     ) -> None: ...
 
 class UniqueConstraint(BaseConstraint):

django-stubs/db/models/fields/mixins.pyi

@@ -1,11 +1,14 @@
 from typing import Any
 
 from django.db.models.base import Model
+from django.utils.functional import cached_property
 
 NOT_PROVIDED: Any
 
 class FieldCacheMixin:
     def get_cache_name(self) -> str: ...
+    @cached_property
+    def cache_name(self) -> str: ...
     def get_cached_value(self, instance: Model, default: Any = ...) -> Model | None: ...
     def is_cached(self, instance: Model) -> bool: ...
     def set_cached_value(self, instance: Model, value: Model | None) -> None: ...

tests/assert_type/db/models/test_constraints.py

@@ -13,4 +13,4 @@
     name="unique_mess",
 )
 
-CheckConstraint(name="less_than_constraint", check=LessThan[Any](F("months"), 1))
+CheckConstraint(name="less_than_constraint", check=LessThan[Any](F("months"), 1))  # pyright: ignore[reportDeprecated]