Skip to content

Commit ac84848

Browse files
ref: remove incr_version / decr_version (#15)
these methods are unsafe with our usage of cache
1 parent dde0f3c commit ac84848

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

django-stubs/core/cache/backends/base.pyi

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ class BaseCache:
6060
async def adelete_many(self, keys: Iterable[Any], version: Any | None = ...) -> None: ...
6161
def clear(self) -> None: ...
6262
async def aclear(self) -> None: ...
63-
def incr_version(self, key: Any, delta: int = ..., version: Any | None = ...) -> int: ...
64-
async def aincr_version(self, key: Any, delta: int = ..., version: Any | None = ...) -> int: ...
65-
def decr_version(self, key: Any, delta: int = ..., version: Any | None = ...) -> int: ...
66-
async def adecr_version(self, key: Any, delta: int = ..., version: Any | None = ...) -> int: ...
6763
def close(self, **kwargs: Any) -> None: ...
6864
async def aclose(self, **kwargs: Any) -> None: ...
6965

scripts/stubtest/allowlist.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,3 +411,13 @@ django.contrib.sessions.base_session.AbstractBaseSession.Meta
411411
# Custom __str__ that we don't want to overcomplicate:
412412
django.forms.utils.RenderableMixin.__str__
413413
django.forms.utils.RenderableMixin.__html__
414+
415+
# sentry: we remove these methods because they are unsafe for our usage
416+
django.core.cache.BaseCache.adecr_version
417+
django.core.cache.BaseCache.aincr_version
418+
django.core.cache.BaseCache.decr_version
419+
django.core.cache.BaseCache.incr_version
420+
django.core.cache.backends.base.BaseCache.adecr_version
421+
django.core.cache.backends.base.BaseCache.aincr_version
422+
django.core.cache.backends.base.BaseCache.decr_version
423+
django.core.cache.backends.base.BaseCache.incr_version

0 commit comments

Comments
 (0)