Skip to content

Commit d5b731b

Browse files
ref: remove incr_version / decr_version (#15)
these methods are unsafe with our usage of cache
1 parent 0a76599 commit d5b731b

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

django-stubs/core/cache/backends/base.pyi

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ class BaseCache:
6060
async def adelete_many(self, keys: Iterable[Any], version: Any | None = None) -> None: ...
6161
def clear(self) -> None: ...
6262
async def aclear(self) -> None: ...
63-
def incr_version(self, key: Any, delta: int = 1, version: Any | None = None) -> int: ...
64-
async def aincr_version(self, key: Any, delta: int = 1, version: Any | None = None) -> int: ...
65-
def decr_version(self, key: Any, delta: int = 1, version: Any | None = None) -> int: ...
66-
async def adecr_version(self, key: Any, delta: int = 1, version: Any | None = None) -> int: ...
6763
def close(self, **kwargs: Any) -> None: ...
6864
async def aclose(self, **kwargs: Any) -> None: ...
6965

scripts/stubtest/allowlist.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,16 @@ django.contrib.auth.views.UserModel
228228
django.contrib.sessions.backends.base.SessionBase.get
229229
django.contrib.sessions.backends.base.SessionBase.setdefault
230230

231+
# sentry: we remove these methods because they are unsafe for our usage
232+
django.core.cache.BaseCache.adecr_version
233+
django.core.cache.BaseCache.aincr_version
234+
django.core.cache.BaseCache.decr_version
235+
django.core.cache.BaseCache.incr_version
236+
django.core.cache.backends.base.BaseCache.adecr_version
237+
django.core.cache.backends.base.BaseCache.aincr_version
238+
django.core.cache.backends.base.BaseCache.decr_version
239+
django.core.cache.backends.base.BaseCache.incr_version
240+
231241
# Limited stubtest support for enums (https://github.com/python/mypy/issues/16806)
232242
django.db.migrations.operations.base.OperationCategory.__new__
233243

0 commit comments

Comments
 (0)