`SetUser` does not work when called after starting a span

[OrkhanAlikhanov]

I have this code:

func SetUserProfile(ctx context.Context, profile *models.UserProfile) error {
	span := sentry.StartSpan(ctx, "method", sentry.WithDescription("SetUserProfile"))
	defer span.Finish()

	ctx = span.Context()

	err := setProfile(profile)
	if err != nil {
		return err
	}

	sentry.ConfigureScope(func(scope *sentry.Scope) {
		scope.SetUser(sentry.User{
			ID:       profile.ID,
			Email:    profile.Email,
			Username: profile.Username,
			Name:     profile.FullName,
		})
	})

	return nil
}

But it doesn't set user when I call sentry.StartSpan in it:

func run() {
    tr := sentry.StartTransaction(context.Background(), "Command: run")
    defer tr.Finish()
    ctx := tr.Context()

    // ... 

    SetUserProfile(ctx, profile)

    // ...
     
    if err != nil {
        sentry.CaptureError(err) // no user reported
    }
}

After debugging it looks like it happens because StartSpan pushes new scope and SetUser is called on that not at the root scope.

[aldy505]

Does this works for you?

func SetUserProfile(ctx context.Context, profile *models.UserProfile) error {
	span := sentry.StartSpan(ctx, "method", sentry.WithDescription("SetUserProfile"))
	defer span.Finish()

	ctx = span.Context()

	err := setProfile(profile)
	if err != nil {
		return err
	}

	sentry.GetHubFromContext(ctx).Scope().SetUser(sentry.User{
		ID:       profile.ID,
		Email:    profile.Email,
		Username: profile.Username,
		Name:     profile.FullName,
	})

	return nil
}

Also, I'd recommend using

sentry.GetHubFromContext(ctx).CaptureException(err)

instead of directly

sentry.CaptureException(err)

[OrkhanAlikhanov]

Hello, thanks for taking a look. I'm actually passing a cloned hub and already using sentry.GetHubFromContext(ctx).Scope().SetUser(...) to set the user. The issue is that, when sentry.StartSpan is called it pushes new scope to the stack and sentry.GetHubFromContext(ctx).Scope() returns that scope. Since user is set on that scope not the root one, it's lost once it's popped on span.Finish() call

[giortzisg]

Let me have a look and get back to you.

[cleptric]

Opened #1013 to fix this.