Add user details when DefaultPII is enabled#1018
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 85.45% 85.50% +0.05%
==========================================
Files 55 55
Lines 5486 5500 +14
==========================================
+ Hits 4688 4703 +15
Misses 653 653
+ Partials 145 144 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cleptric
reviewed
Jun 3, 2025
log.go
Outdated
| attrs["sentry.server.address"] = Attribute{Value: serverAddr, Type: "string"} | ||
| } | ||
| if l.client.options.SendDefaultPII { | ||
| user := GetHubFromContext(ctx).Scope().user |
Member
There was a problem hiding this comment.
GetHubFromContext(ctx) might return nil
log.go
Outdated
Comment on lines
+126
to
+128
| attrs["user.id"] = Attribute{Value: user.ID, Type: "string"} | ||
| attrs["user.name"] = Attribute{Value: user.Name, Type: "string"} | ||
| attrs["user.email"] = Attribute{Value: user.Email, Type: "string"} |
cleptric
reviewed
Jun 3, 2025
cleptric
reviewed
Jun 3, 2025
| ServerName: "test-server", | ||
| EnableLogs: true, | ||
| EnableTracing: true, | ||
| SendDefaultPII: true, |
Member
There was a problem hiding this comment.
Should also have a test that does the reverse.
cleptric
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1017 .
When
SendDefaultPIIis enabled, we should be adding user details on the logs payload.