Skip to content

Commit 2f8360a

Browse files
Move SentrySpanClientHttpRequestInterceptor to Spring module. (#1181)
Fixes #1178.
1 parent 18b003d commit 2f8360a

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
* Enhancement: Pass request to CustomSamplingContext in Spring integration (#1172)
55
* Ref: Set SpanContext on SentryTransaction to avoid potential NPE (#1173)
66
* Fix: Free Local Refs manually due to Android local ref. count limits
7-
* Fix: Bring back support for setting transaction name without ongoing transaction (#1183)
7+
* Enhancement: Move `SentrySpanClientHttpRequestInterceptor` to Spring module (#1181)
88
* Enhancement: Add overload for `transaction/span.finish(SpanStatus)` (#1182)
9+
* Fix: Bring back support for setting transaction name without ongoing transaction (#1183)
910
* Enhancement: Simplify registering traces sample callback in Spring integration (#1184)
1011

1112
# 4.0.0-alpha.3

sentry-spring-boot-starter/src/main/java/io/sentry/spring/boot/SentrySpanRestTemplateCustomizer.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.jakewharton.nopen.annotation.Open;
44
import io.sentry.IHub;
5+
import io.sentry.spring.tracing.SentrySpanClientHttpRequestInterceptor;
56
import java.util.ArrayList;
67
import java.util.List;
78
import org.jetbrains.annotations.NotNull;

sentry-spring/api/sentry-spring.api

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ public class io/sentry/spring/tracing/SentrySpanAdvice : org/aopalliance/interce
7676
public fun invoke (Lorg/aopalliance/intercept/MethodInvocation;)Ljava/lang/Object;
7777
}
7878

79+
public class io/sentry/spring/tracing/SentrySpanClientHttpRequestInterceptor : org/springframework/http/client/ClientHttpRequestInterceptor {
80+
public fun <init> (Lio/sentry/IHub;)V
81+
public fun createUriTemplateHandler (Lorg/springframework/web/util/UriTemplateHandler;)Lorg/springframework/web/util/UriTemplateHandler;
82+
public fun intercept (Lorg/springframework/http/HttpRequest;[BLorg/springframework/http/client/ClientHttpRequestExecution;)Lorg/springframework/http/client/ClientHttpResponse;
83+
}
84+
7985
public class io/sentry/spring/tracing/SentryTracingFilter : org/springframework/web/filter/OncePerRequestFilter {
8086
public fun <init> (Lio/sentry/IHub;Lio/sentry/SentryOptions;Lio/sentry/spring/SentryRequestResolver;)V
8187
protected fun doFilterInternal (Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Ljavax/servlet/FilterChain;)V
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.sentry.spring.boot;
1+
package io.sentry.spring.tracing;
22

33
import com.jakewharton.nopen.annotation.Open;
44
import io.sentry.IHub;
@@ -21,7 +21,7 @@
2121
import org.springframework.web.util.UriTemplateHandler;
2222

2323
@Open
24-
class SentrySpanClientHttpRequestInterceptor implements ClientHttpRequestInterceptor {
24+
public class SentrySpanClientHttpRequestInterceptor implements ClientHttpRequestInterceptor {
2525
private static final @NotNull ThreadLocal<Deque<String>> urlTemplate =
2626
new UrlTemplateThreadLocal();
2727
private final @NotNull IHub hub;
@@ -60,7 +60,8 @@ public SentrySpanClientHttpRequestInterceptor(final @NotNull IHub hub) {
6060
}
6161
}
6262

63-
UriTemplateHandler createUriTemplateHandler(final @NotNull UriTemplateHandler delegate) {
63+
public @NotNull UriTemplateHandler createUriTemplateHandler(
64+
final @NotNull UriTemplateHandler delegate) {
6465
return new UriTemplateHandler() {
6566

6667
@Override

0 commit comments

Comments
 (0)