Skip to content

Commit 31c8b80

Browse files
committed
update test
1 parent 149d2e1 commit 31c8b80

File tree

2 files changed

+28
-4
lines changed

2 files changed

+28
-4
lines changed

sentry-android-ndk/src/main/java/io/sentry/android/ndk/DebugImagesLoader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ public DebugImagesLoader(
9393
}
9494

9595
Set<DebugImage> relevantImages = new LinkedHashSet<>();
96-
for (Long address : addresses) {
97-
DebugImage image = findImageByAddress(address, allDebugImages);
96+
for (Long addr : addresses) {
97+
DebugImage image = findImageByAddress(addr, allDebugImages);
9898
if (image != null) {
9999
relevantImages.add(image);
100100
}

sentry-android-ndk/src/test/java/io/sentry/android/ndk/DebugImagesLoaderTest.kt

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package io.sentry.android.ndk
33
import io.sentry.android.core.SentryAndroidOptions
44
import io.sentry.ndk.NativeModuleListLoader
55
import org.junit.Assert.assertEquals
6+
import org.junit.Assert.assertNull
67
import org.mockito.kotlin.mock
78
import org.mockito.kotlin.verify
89
import org.mockito.kotlin.whenever
@@ -81,7 +82,7 @@ class DebugImagesLoaderTest {
8182
}
8283

8384
@Test
84-
fun testFindImageByAddress() {
85+
fun `find images by address`() {
8586
val sut = fixture.getSut()
8687

8788
val image1 = io.sentry.ndk.DebugImage().apply {
@@ -111,8 +112,9 @@ class DebugImagesLoaderTest {
111112
}
112113

113114
@Test
114-
fun testInvalidHexAddress() {
115+
fun `find images with invalid addresses are not added to the result`() {
115116
val sut = fixture.getSut()
117+
116118
val image1 = io.sentry.ndk.DebugImage().apply {
117119
imageAddr = "0x1000"
118120
imageSize = 0x1000L
@@ -130,4 +132,26 @@ class DebugImagesLoaderTest {
130132

131133
assertEquals(1, result!!.size)
132134
}
135+
136+
@Test
137+
fun `find images by address returns null if result is empty`() {
138+
val sut = fixture.getSut()
139+
140+
val image1 = io.sentry.ndk.DebugImage().apply {
141+
imageAddr = "0x1000"
142+
imageSize = 0x1000L
143+
}
144+
145+
val image2 = io.sentry.ndk.DebugImage().apply {
146+
imageAddr = "0x2000"
147+
imageSize = 0x1000L
148+
}
149+
150+
whenever(fixture.nativeLoader.loadModuleList()).thenReturn(arrayOf(image1, image2))
151+
152+
val hexAddresses = setOf(-100, 0x10500L)
153+
val result = sut.loadDebugImagesForAddresses(hexAddresses)
154+
155+
assertNull(result)
156+
}
133157
}

0 commit comments

Comments
 (0)