Skip to content

Commit 4d7e996

Browse files
authored
Merge branch 'main' into fix/avoid-log-floats
2 parents dcf8e00 + 926429a commit 4d7e996

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
## 8.0.0
1010

11+
### Summary
12+
1113
Version 8 of the Sentry Android/Java SDK brings a variety of features and fixes. The most notable changes are:
1214

1315
- `Hub` has been replaced by `Scopes`

sentry/src/test/java/io/sentry/transport/RateLimiterTest.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ import org.mockito.kotlin.verifyNoMoreInteractions
3939
import org.mockito.kotlin.whenever
4040
import java.io.File
4141
import java.util.UUID
42+
import java.util.concurrent.CountDownLatch
43+
import java.util.concurrent.TimeUnit
4244
import java.util.concurrent.atomic.AtomicBoolean
4345
import kotlin.test.Test
4446
import kotlin.test.assertEquals
@@ -363,18 +365,17 @@ class RateLimiterTest {
363365
val rateLimiter = fixture.getSUT()
364366
whenever(fixture.currentDateProvider.currentTimeMillis).thenReturn(0, 1, 2001)
365367

366-
val applied = AtomicBoolean(true)
368+
val applied = CountDownLatch(1)
369+
var activeForReplay = false
367370
rateLimiter.addRateLimitObserver {
368-
applied.set(rateLimiter.isActiveForCategory(Replay))
371+
applied.countDown()
372+
activeForReplay = rateLimiter.isActiveForCategory(Replay)
369373
}
370374

371375
rateLimiter.updateRetryAfterLimits("1:replay:key", null, 1)
372376
rateLimiter.close()
373377

374-
// If rate limit didn't already change, wait for 1.5s to ensure the timer has run after 1s
375-
if (!applied.get()) {
376-
await.untilTrue(applied)
377-
}
378-
assertTrue(applied.get())
378+
applied.await(2, TimeUnit.SECONDS)
379+
assertTrue(activeForReplay)
379380
}
380381
}

0 commit comments

Comments
 (0)