Skip to content

Commit 9961579

Browse files
authored
feat: Milliseconds to breadcrumbs (#777)
* resolves #776
1 parent edd7227 commit 9961579

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

sentry/src/main/java/io/sentry/marshaller/json/JsonMarshaller.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,10 @@ private void writeBreadcumbs(JsonGenerator generator, List<Breadcrumb> breadcrum
295295
generator.writeArrayFieldStart("values");
296296
for (Breadcrumb breadcrumb : breadcrumbs) {
297297
generator.writeStartObject();
298-
// getTime() returns ts in millis, but breadcrumbs expect seconds
299-
generator.writeNumberField("timestamp", breadcrumb.getTimestamp().getTime() / 1000);
298+
TimeZone tz = TimeZone.getTimeZone("UTC");
299+
DateFormat df = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");
300+
df.setTimeZone(tz);
301+
generator.writeStringField("timestamp", df.format(breadcrumb.getTimestamp()));
300302

301303
if (breadcrumb.getType() != null) {
302304
generator.writeStringField("type", breadcrumb.getType().getValue());

sentry/src/test/java/io/sentry/marshaller/json/JsonMarshallerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,13 +245,13 @@ public void testEventBreadcrumbsWrittenProperly() throws Exception {
245245
final JsonOutputStreamParser jsonOutputStreamParser = newJsonOutputStream();
246246

247247
Breadcrumb breadcrumb1 = new BreadcrumbBuilder()
248-
.setTimestamp(new Date(1463169342000L))
248+
.setTimestamp(new Date(1463169342123L))
249249
.setLevel(Breadcrumb.Level.INFO)
250250
.setCategory("foo")
251251
.setMessage("test1")
252252
.build();
253253
Breadcrumb breadcrumb2 = new BreadcrumbBuilder()
254-
.setTimestamp(new Date(1463169343000L))
254+
.setTimestamp(new Date(1463169343111L))
255255
.setLevel(Breadcrumb.Level.INFO)
256256
.setCategory("foo")
257257
.setMessage("test2")

sentry/src/test/resources/io/sentry/marshaller/json/jsonmarshallertest/testBreadcrumbs.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
"breadcrumbs": {
1818
"values": [
1919
{
20-
"timestamp": 1463169342,
20+
"timestamp": "2016-05-13T19:55:42.123Z",
2121
"level": "info",
2222
"message": "test1",
2323
"category": "foo"
2424
},
2525
{
26-
"timestamp": 1463169343,
26+
"timestamp": "2016-05-13T19:55:43.111Z",
2727
"level": "info",
2828
"message": "test2",
2929
"category": "foo"

0 commit comments

Comments
 (0)