Fix lint tests (#1575)

Author: marandaneto

sentry-android-okhttp/src/test/java/io/sentry/android/okhttp/SentryOkHttpInterceptorTest.kt

@@ -185,17 +185,16 @@ class SentryOkHttpInterceptorTest {
 
     @Test
     fun `customizer receives request and response`() {
-        var request: Request? = null
         val sut = fixture.getSut(beforeSpan = object : SentryOkHttpInterceptor.BeforeSpanCallback {
-            override fun execute(span: ISpan, req: Request, res: Response?): ISpan {
-            assertEquals(request!!.url, req.url)
-            assertEquals(request!!.method, req.method)
-            assertNotNull(res) {
+            override fun execute(span: ISpan, request: Request, response: Response?): ISpan {
+            assertEquals(request.url, request.url)
+            assertEquals(request.method, request.method)
+            assertNotNull(response) {
                 assertEquals(201, it.code)
             }
             return span
         } })
-        request = getRequest()
+        val request = getRequest()
         sut.newCall(request).execute()
     }
 

sentry-servlet/src/test/kotlin/io/sentry/servlet/SentryRequestHttpServletRequestProcessorTest.kt

@@ -91,8 +91,8 @@ class SentryRequestHttpServletRequestProcessorTest {
 
         eventProcessor.process(event, null)
 
-        assertNotNull(event.request) { request ->
-            assertNotNull(request.headers) {
+        assertNotNull(event.request) { req ->
+            assertNotNull(req.headers) {
                 assertFalse(it.containsKey("X-FORWARDED-FOR"))
                 assertFalse(it.containsKey("Authorization"))
                 assertFalse(it.containsKey("authorization"))

sentry-spring-boot-starter/src/test/kotlin/io/sentry/spring/boot/it/SentrySpringIntegrationTest.kt

@@ -64,7 +64,7 @@ class SentrySpringIntegrationTest {
     lateinit var hub: IHub
 
     @LocalServerPort
-    lateinit var port: Integer
+    var port: Int? = null
 
     @Before
     fun reset() {

sentry-spring/src/test/kotlin/io/sentry/spring/mvc/SentrySpringIntegrationTest.kt

@@ -77,7 +77,7 @@ class SentrySpringIntegrationTest {
     lateinit var hub: IHub
 
     @LocalServerPort
-    lateinit var port: Integer
+    var port: Int? = null
 
     @Before
     fun `reset mocks`() {

sentry-spring/src/test/kotlin/io/sentry/spring/webflux/SentryWebfluxIntegrationTest.kt

@@ -51,7 +51,7 @@ class SentryWebfluxIntegrationTest {
     lateinit var transport: ITransport
 
     @LocalServerPort
-    lateinit var port: Integer
+    var port: Int? = null
 
     private val testClient = WebTestClient.bindToServer().build()
 

sentry/src/main/java/io/sentry/OptionsContainer.java

@@ -7,11 +7,11 @@
 @ApiStatus.Internal
 public final class OptionsContainer<T> {
 
-  public static <T> OptionsContainer<T> create(final Class<T> clazz) {
+  public @NotNull static <T> OptionsContainer<T> create(final @NotNull Class<T> clazz) {
     return new OptionsContainer<>(clazz);
   }
 
-  private final Class<T> clazz;
+  private final @NotNull Class<T> clazz;
 
   private OptionsContainer(final @NotNull Class<T> clazz) {
     super();

sentry/src/test/java/io/sentry/config/PropertiesProviderTest.kt

@@ -28,15 +28,15 @@ class PropertiesProviderTest {
     }
 
     @Test
-    fun `when property is value is "true" returns true`() {
+    fun `when property is value is true returns true`() {
         whenever(propertiesProvider.getProperty(any())).thenReturn("true")
         val result = propertiesProvider.getBooleanProperty("prop")
         assertNotNull(result)
         assertTrue(result)
     }
 
     @Test
-    fun `when property is value is "false" returns false`() {
+    fun `when property is value is false returns false`() {
         whenever(propertiesProvider.getProperty(any())).thenReturn("false")
         val result = propertiesProvider.getBooleanProperty("prop")
         assertNotNull(result)