All status codes below 400 are now mapped to SpanStatus.OK (#3869)

* Auto config for Spring Boot combined with OTel but without agent

* try to cleanup otel classloader

* make agent, no agent and agent without auto init work for spring boot

* Fix ignored instrumentation for OTel without agent; separate sample for no agent

* fix test result upload on CI

* automatically detect otel and use OtelSpanFactory

* POTEL 54 cleanup

* fix non current span start child

* consider status codes below 400 to be OK

* changelog

* remove file that re-emerged during merge

Author: adinauer

CHANGELOG.md

@@ -9,6 +9,7 @@
   - `Session.getSessionId()` now returns a `String` instead of a `UUID`.
 - The Android minSdk level for all Android modules is now 21 ([#3852](https://github.com/getsentry/sentry-java/pull/3852))
 - The minSdk level for sentry-android-ndk changed from 19 to 21 ([#3851](https://github.com/getsentry/sentry-java/pull/3851))
+- All status codes below 400 are now mapped to `SpanStatus.OK` ([#3869](https://github.com/getsentry/sentry-java/pull/3869))
 
 ### Features
 
@@ -48,6 +49,7 @@
 - Add `auto.graphql.graphql22` to ignored span origins when using OpenTelemetry ([#3828](https://github.com/getsentry/sentry-java/pull/3828))
 - The Spring Boot 3 WebFlux sample now uses our GraphQL v22 integration ([#3828](https://github.com/getsentry/sentry-java/pull/3828))
 - Accept manifest integer values when requiring floating values ([#3823](https://github.com/getsentry/sentry-java/pull/3823))
+- All status codes below 400 are now mapped to `SpanStatus.OK` ([#3869](https://github.com/getsentry/sentry-java/pull/3869))
 
 
 ### Dependencies

sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/opentelemetry/SentryOpenTelemetryConfiguration.java

@@ -126,7 +126,7 @@ class SentryTracingFilterTest {
 
     @Test
     fun `does not set span status for response status that dont match predefined span statuses`() {
-        val filter = fixture.getSut(status = 302)
+        val filter = fixture.getSut(status = 507)
 
         filter.doFilter(fixture.request, fixture.response, fixture.chain)
 

sentry-spring-jakarta/src/test/kotlin/io/sentry/spring/jakarta/tracing/SentryTracingFilterTest.kt

@@ -146,7 +146,7 @@ class SentryWebFluxTracingFilterTest {
 
     @Test
     fun `does not set span status for response status that dont match predefined span statuses`() {
-        val filter = fixture.getSut(status = HttpStatus.FOUND)
+        val filter = fixture.getSut(status = HttpStatus.INSUFFICIENT_STORAGE)
 
         withMockScopes {
             filter.filter(fixture.exchange, fixture.chain).block()

sentry-spring-jakarta/src/test/kotlin/io/sentry/spring/jakarta/webflux/SentryWebFluxTracingFilterTest.kt

@@ -126,7 +126,7 @@ class SentryTracingFilterTest {
 
     @Test
     fun `does not set span status for response status that dont match predefined span statuses`() {
-        val filter = fixture.getSut(status = 302)
+        val filter = fixture.getSut(status = 507)
 
         filter.doFilter(fixture.request, fixture.response, fixture.chain)
 

sentry-spring/src/test/kotlin/io/sentry/spring/tracing/SentryTracingFilterTest.kt

@@ -147,7 +147,7 @@ class SentryWebFluxTracingFilterTest {
 
     @Test
     fun `does not set span status for response status that dont match predefined span statuses`() {
-        val filter = fixture.getSut(status = HttpStatus.FOUND)
+        val filter = fixture.getSut(status = HttpStatus.INSUFFICIENT_STORAGE)
 
         withMockScopes {
             filter.filter(fixture.exchange, fixture.chain).block()

sentry-spring/src/test/kotlin/io/sentry/spring/webflux/SentryWebFluxTracingFilterTest.kt

@@ -7,7 +7,7 @@
 
 public enum SpanStatus implements JsonSerializable {
   /** Not an error, returned on success. */
-  OK(200, 299),
+  OK(0, 399),
   /** The operation was cancelled, typically by the caller. */
   CANCELLED(499),
   /**

sentry/src/main/java/io/sentry/SpanStatus.java

@@ -21,14 +21,19 @@ class SpanStatusTest {
         assertEquals(SpanStatus.INTERNAL_ERROR, SpanStatus.fromHttpStatusCode(500))
     }
 
+    @Test
+    fun `code 3xx is now also considered OK`() {
+        assertEquals(SpanStatus.OK, SpanStatus.fromHttpStatusCode(304))
+    }
+
     @Test
     fun `returns null when no SpanStatus matches specific code`() {
-        assertNull(SpanStatus.fromHttpStatusCode(302))
+        assertNull(SpanStatus.fromHttpStatusCode(599))
     }
 
     @Test
     fun `returns default value when no SpanStatus matches specific code`() {
-        assertEquals(SpanStatus.UNKNOWN_ERROR, SpanStatus.fromHttpStatusCode(302, SpanStatus.UNKNOWN_ERROR))
+        assertEquals(SpanStatus.UNKNOWN_ERROR, SpanStatus.fromHttpStatusCode(599, SpanStatus.UNKNOWN_ERROR))
     }
 
     @Test