Skip to content

Enable Backpressure Management by Default #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Enable Backpressure Management by Default #3284

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18ecfee
enable backpressure management by default
adinauer Mar 25, 2024
0bf0cea
Merge branch 'main' into feat/backpressure-opt-out
adinauer Mar 25, 2024
7909075
changelog
adinauer Mar 26, 2024
07c106b
adapt tests
adinauer Mar 26, 2024
0a8eb59
Merge branch 'main' into feat/backpressure-opt-out
adinauer Apr 8, 2024
3dc1f96
change auto config tests
adinauer Apr 9, 2024
3ed49b8
Merge branch 'main' into feat/backpressure-opt-out
adinauer Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/Sentry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ private static boolean initConfigurations(final @NotNull SentryOptions options)
options.addPerformanceCollector(new JavaMemoryCollector());
}

if (options.isEnableBackpressureHandling()) {
if (options.isEnableBackpressureHandling() && Platform.isJvm()) {
Copy link
Member Author

@adinauer adinauer Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's currently no way of disabling backpressure for Android via Metadata I only enable it for backend. There usually shouldn't be as high a volume of transactions on Android.

Copy link
Member Author

@adinauer adinauer Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided in Backend Daily it's OK to disable backpressure management for Android. If we ever want it we'll have to make it configurable and probably do a separate test phase before enabling it by default there.

options.setBackpressureMonitor(new BackpressureMonitor(options, HubAdapter.getInstance()));
options.getBackpressureMonitor().start();
}
Expand Down
3 changes: 1 addition & 2 deletions sentry/src/main/java/io/sentry/SentryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,10 +454,9 @@ public class SentryOptions {
/** Contains a list of monitor slugs for which check-ins should not be sent. */
@ApiStatus.Experimental private @Nullable List<String> ignoredCheckIns = null;

@ApiStatus.Experimental
private @NotNull IBackpressureMonitor backpressureMonitor = NoOpBackpressureMonitor.getInstance();

@ApiStatus.Experimental private boolean enableBackpressureHandling = false;
private boolean enableBackpressureHandling = true;

/** Whether to profile app launches, depending on profilesSampler or profilesSampleRate. */
private boolean enableAppStartProfiling = false;
Expand Down