Skip to content

fix: handle unparseable mime-type #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+40 −6
Open

fix: handle unparseable mime-type #4939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3724d79
fix: handle unparseable mime-type
diogoosorio Nov 28, 2025
96459c5
fix: apply same catch on sentry-spring-7
diogoosorio Nov 28, 2025
c306b63
chore: add CHANGELOG
diogoosorio Nov 28, 2025
aeb9fcb
change Spring Boot 3 / Spring 6 implementation
adinauer Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ SentryAndroid.init(
### Fixes

- Fix missing thread stacks for ANRv1 events ([#4918](https://github.com/getsentry/sentry-java/pull/4918))
- Fix handling of unparseable mime-type on request filter ([#4939](https://github.com/getsentry/sentry-java/pull/4939))

### Internal

Expand Down
9 changes: 7 additions & 2 deletions sentry-spring-7/src/main/java/io/sentry/spring7/SentrySpringFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.springframework.http.MediaType;
import org.springframework.util.InvalidMimeTypeException;
import org.springframework.util.MimeType;
import org.springframework.web.filter.OncePerRequestFilter;
import org.springframework.web.util.ContentCachingRequestWrapper;
Expand Down Expand Up @@ -131,8 +132,12 @@ && shouldCacheMimeType(contentType)
}

private static boolean shouldCacheMimeType(String contentType) {
return MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_JSON)
|| MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_FORM_URLENCODED);
try {
return MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_JSON)
|| MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_FORM_URLENCODED);
} catch (InvalidMimeTypeException e) {
return false;
}
}

static final class RequestBodyExtractingEventProcessor implements EventProcessor {
Expand Down
6 changes: 6 additions & 0 deletions sentry-spring-7/src/test/kotlin/io/sentry/spring7/SentrySpringFilterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ class SentrySpringFilterTest {
body = "x".repeat(10001),
expectedToBeCached = false,
),
TestParams(
maxRequestBodySize = MEDIUM,
body = "xxx",
expectedToBeCached = false,
contentType = "invalid",
),
TestParams(
maxRequestBodySize = ALWAYS,
body = "x".repeat(10001),
Expand Down
9 changes: 7 additions & 2 deletions sentry-spring-jakarta/src/main/java/io/sentry/spring/jakarta/SentrySpringFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.springframework.http.MediaType;
import org.springframework.util.InvalidMimeTypeException;
import org.springframework.util.MimeType;
import org.springframework.web.filter.OncePerRequestFilter;
import org.springframework.web.util.ContentCachingRequestWrapper;
Expand Down Expand Up @@ -131,8 +132,12 @@ && shouldCacheMimeType(contentType)
}

private static boolean shouldCacheMimeType(String contentType) {
return MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_JSON)
|| MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_FORM_URLENCODED);
try {
return MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_JSON)
|| MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_FORM_URLENCODED);
} catch (InvalidMimeTypeException e) {
return false;
}
}

static final class RequestBodyExtractingEventProcessor implements EventProcessor {
Expand Down
6 changes: 6 additions & 0 deletions sentry-spring-jakarta/src/test/kotlin/io/sentry/spring/jakarta/SentrySpringFilterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ class SentrySpringFilterTest {
body = "x".repeat(10001),
expectedToBeCached = false,
),
TestParams(
maxRequestBodySize = MEDIUM,
body = "xxx",
expectedToBeCached = false,
contentType = "invalid",
),
TestParams(
maxRequestBodySize = ALWAYS,
body = "x".repeat(10001),
Expand Down
9 changes: 7 additions & 2 deletions sentry-spring/src/main/java/io/sentry/spring/SentrySpringFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.springframework.http.MediaType;
import org.springframework.util.InvalidMimeTypeException;
import org.springframework.util.MimeType;
import org.springframework.web.filter.OncePerRequestFilter;
import org.springframework.web.util.ContentCachingRequestWrapper;
Expand Down Expand Up @@ -131,8 +132,12 @@ && shouldCacheMimeType(contentType)
}

private static boolean shouldCacheMimeType(String contentType) {
return MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_JSON)
|| MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_FORM_URLENCODED);
try {
return MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_JSON)
|| MimeType.valueOf(contentType).isCompatibleWith(MediaType.APPLICATION_FORM_URLENCODED);
} catch (InvalidMimeTypeException e) {
return false;
}
}

static final class RequestBodyExtractingEventProcessor implements EventProcessor {
Expand Down
6 changes: 6 additions & 0 deletions sentry-spring/src/test/kotlin/io/sentry/spring/SentrySpringFilterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ class SentrySpringFilterTest {
body = "x".repeat(10001),
expectedToBeCached = false,
),
TestParams(
maxRequestBodySize = MEDIUM,
body = "xxx",
expectedToBeCached = false,
contentType = "invalid",
),
TestParams(
maxRequestBodySize = ALWAYS,
body = "x".repeat(10001),
Expand Down
Loading