chore(core): Remove unused dependencies (#110)

Removes a few dependencies we don't need anymore after switching back to Sentry CLI. 
Makes adjustments to `captureMinimalError` to no longer treat axios errors (axios was one of the removed dependencies)

Author: Lms24

packages/bundler-plugin-core/package.json

@@ -38,10 +38,6 @@
     "@sentry/cli": "^1.74.6",
     "@sentry/node": "^7.11.1",
     "@sentry/tracing": "^7.11.1",
-    "axios": "^0.27.2",
-    "form-data": "^4.0.0",
-    "glob": "8.0.3",
-    "ignore": "^5.2.0",
     "magic-string": "0.26.2",
     "unplugin": "0.10.1"
   },
@@ -58,7 +54,6 @@
     "@sentry-internal/sentry-bundler-plugin-tsconfig": "0.0.1-alpha.0",
     "@swc/core": "^1.2.205",
     "@swc/jest": "^0.2.21",
-    "@types/glob": "8.0.0",
     "@types/jest": "^28.1.3",
     "@types/node": "^18.6.3",
     "eslint": "^8.18.0",

packages/bundler-plugin-core/src/sentry/telemetry.ts

@@ -7,7 +7,6 @@ import {
   NodeClient,
 } from "@sentry/node";
 import { Span } from "@sentry/tracing";
-import { AxiosError } from "axios";
 import { BuildContext } from "../types";
 
 export function makeSentryClient(
@@ -57,16 +56,23 @@ export function addSpanToTransaction(
   return span;
 }
 
-export function captureMinimalError(error: unknown | Error | AxiosError, hub: Hub) {
-  const isAxiosError = error instanceof AxiosError;
-  const sentryError =
-    error instanceof Error
-      ? {
-          name: `${isAxiosError && error.status ? error.status : ""}: ${error.name}`,
-          message: error.message,
-          stack: error.stack,
-        }
-      : {};
+export function captureMinimalError(error: unknown | Error, hub: Hub) {
+  let sentryError;
+
+  if (error && typeof error === "object") {
+    const e = error as { name?: string; message?: string; stack?: string };
+    sentryError = {
+      name: e.name,
+      message: e.message,
+      stack: e.stack,
+    };
+  } else {
+    sentryError = {
+      name: "Error",
+      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
+      message: `${error}`,
+    };
+  }
 
   hub.captureException(sentryError);
 }

…ges/bundler-plugin-core/test/cli.test.ts …dler-plugin-core/test/sentry/cli.test.tspackages/bundler-plugin-core/test/cli.test.ts renamed to packages/bundler-plugin-core/test/sentry/cli.test.ts packages/bundler-plugin-core/test/cli.test.ts renamed to packages/bundler-plugin-core/test/sentry/cli.test.ts

@@ -1,5 +1,5 @@
 import SentryCli from "@sentry/cli";
-import { getSentryCli } from "../src/sentry/cli";
+import { getSentryCli } from "../../src/sentry/cli";
 
 describe("getSentryCLI", () => {
   it("returns a valid CLI instance if dryRun is not specified", () => {

…/bundler-plugin-core/test/logger.test.ts …r-plugin-core/test/sentry/logger.test.tspackages/bundler-plugin-core/test/logger.test.ts renamed to packages/bundler-plugin-core/test/sentry/logger.test.ts packages/bundler-plugin-core/test/logger.test.ts renamed to packages/bundler-plugin-core/test/sentry/logger.test.ts

@@ -1,5 +1,5 @@
 import { Hub } from "@sentry/node";
-import { createLogger } from "../src/sentry/logger";
+import { createLogger } from "../../src/sentry/logger";
 
 describe("Logger", () => {
   const consoleLogSpy = jest.spyOn(console, "log").mockImplementation(() => undefined);

…plugin-core/test/releasePipeline.test.ts …core/test/sentry/releasePipeline.test.tspackages/bundler-plugin-core/test/releasePipeline.test.ts renamed to packages/bundler-plugin-core/test/sentry/releasePipeline.test.ts packages/bundler-plugin-core/test/releasePipeline.test.ts renamed to packages/bundler-plugin-core/test/sentry/releasePipeline.test.ts

@@ -1,19 +1,19 @@
-import { InternalOptions } from "../src/options-mapping";
+import { InternalOptions } from "../../src/options-mapping";
 import {
   addDeploy,
   cleanArtifacts,
   createNewRelease,
   finalizeRelease,
   setCommits,
   uploadSourceMaps,
-} from "../src/sentry/releasePipeline";
-import { BuildContext } from "../src/types";
+} from "../../src/sentry/releasePipeline";
+import { BuildContext } from "../../src/types";
 
 const mockedAddSpanToTxn = jest.fn();
 
-jest.mock("../src/sentry/telemetry", () => {
+jest.mock("../../src/sentry/telemetry", () => {
   // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-  const original = jest.requireActual("../src/sentry/telemetry");
+  const original = jest.requireActual("../../src/sentry/telemetry");
 
   // eslint-disable-next-line @typescript-eslint/no-unsafe-return
   return {

packages/bundler-plugin-core/test/sentry/telemetry.test.ts

@@ -0,0 +1,59 @@
+import { Hub } from "@sentry/node";
+import { captureMinimalError } from "../../src/sentry/telemetry";
+
+describe("captureMinimalError", () => {
+  const mockedHub = {
+    captureException: jest.fn(),
+  };
+
+  beforeEach(() => {
+    jest.resetAllMocks();
+  });
+
+  it("Should capture a normal error", () => {
+    captureMinimalError(new Error("test"), mockedHub as unknown as Hub);
+    expect(mockedHub.captureException).toHaveBeenCalledWith({
+      name: "Error",
+      message: "test",
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      stack: expect.any(String),
+    });
+  });
+
+  it("Shouldn't capture an error with additional data", () => {
+    const error = new Error("test");
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+    (error as any).additionalContext = { foo: "bar" };
+
+    captureMinimalError(error, mockedHub as unknown as Hub);
+
+    expect(mockedHub.captureException).toHaveBeenCalledWith({
+      name: "Error",
+      message: "test",
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      stack: expect.any(String),
+    });
+  });
+
+  it("Should handle string messages gracefully", () => {
+    const error = "Property x is missing!";
+
+    captureMinimalError(error, mockedHub as unknown as Hub);
+
+    expect(mockedHub.captureException).toHaveBeenCalledWith({
+      name: "Error",
+      message: error,
+    });
+  });
+
+  it("Should even handle undefined gracefully", () => {
+    const error = undefined;
+
+    captureMinimalError(error, mockedHub as unknown as Hub);
+
+    expect(mockedHub.captureException).toHaveBeenCalledWith({
+      name: "Error",
+      message: "undefined",
+    });
+  });
+});

yarn.lock

@@ -3837,14 +3837,6 @@ axios@*, axios@^1.0.0, axios@^1.1.3:
     form-data "^4.0.0"
     proxy-from-env "^1.1.0"
 
-axios@^0.27.2:
-  version "0.27.2"
-  resolved "https://registry.yarnpkg.com/axios/-/axios-0.27.2.tgz#207658cc8621606e586c85db4b41a750e756d972"
-  integrity sha512-t+yRIyySRTp/wua5xEr+z1q60QmLq8ABsS5O9Me1AsE5dfKqgnCFzwiCZZ/cGNd1lq4/7akDWMxdhVlucjmnOQ==
-  dependencies:
-    follow-redirects "^1.14.9"
-    form-data "^4.0.0"
-
 babel-jest@^27.5.1:
   version "27.5.1"
   resolved "https://registry.yarnpkg.com/babel-jest/-/babel-jest-27.5.1.tgz#a1bf8d61928edfefd21da27eb86a695bfd691444"
@@ -6183,7 +6175,7 @@ flush-write-stream@^1.0.0:
     inherits "^2.0.3"
     readable-stream "^2.3.6"
 
-follow-redirects@^1.0.0, follow-redirects@^1.14.9:
+follow-redirects@^1.0.0:
   version "1.15.1"
   resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.1.tgz#0ca6a452306c9b276e4d3127483e29575e207ad5"
   integrity sha512-yLAMQs+k0b2m7cVxpS1VKJVvoz7SS9Td1zss3XRwXj+ZDH00RJgnuLx7E44wx02kQLrdM3aOOy+FpzS7+8OizA==