disable debugId upload

Author: chargome

packages/bundler-plugin-core/src/index.ts

@@ -126,24 +126,24 @@ export function sentryUnpluginFactory({
 
     if (!options.sourcemaps?.disable) {
       plugins.push(debugIdInjectionPlugin(logger));
-    }
 
-    // This option is only strongly typed for the webpack plugin, where it is used. It has no effect on other plugins
-    const webpack_forceExitOnBuildComplete =
-      typeof options._experiments["forceExitOnBuildCompletion"] === "boolean"
-        ? options._experiments["forceExitOnBuildCompletion"]
-        : undefined;
-
-    plugins.push(
-      debugIdUploadPlugin(
-        createDebugIdUploadFunction({
-          sentryBuildPluginManager,
-        }),
-        logger,
-        sentryBuildPluginManager.createDependencyOnBuildArtifacts,
-        webpack_forceExitOnBuildComplete
-      )
-    );
+      // This option is only strongly typed for the webpack plugin, where it is used. It has no effect on other plugins
+      const webpack_forceExitOnBuildComplete =
+        typeof options._experiments["forceExitOnBuildCompletion"] === "boolean"
+          ? options._experiments["forceExitOnBuildCompletion"]
+          : undefined;
+
+      plugins.push(
+        debugIdUploadPlugin(
+          createDebugIdUploadFunction({
+            sentryBuildPluginManager,
+          }),
+          logger,
+          sentryBuildPluginManager.createDependencyOnBuildArtifacts,
+          webpack_forceExitOnBuildComplete
+        )
+      );
+    }
 
     if (options.reactComponentAnnotation) {
       if (!options.reactComponentAnnotation.enabled) {

packages/integration-tests/fixtures/disabled-sourcemaps-upload/disabled-sourcemaps-upload.test.ts

@@ -0,0 +1,45 @@
+import path from "path";
+
+import * as rollup from "rollup";
+import { sentryRollupPlugin } from "@sentry/rollup-plugin";
+
+function getGlobalWithDebugIdUploads(): typeof global & {
+  __SENTRY_DEBUG_ID_UPLOAD_TEST__?: boolean;
+} {
+  return global;
+}
+
+test("should not call upload plugin when sourcemaps are disabled", async () => {
+  const gbl = getGlobalWithDebugIdUploads();
+  gbl.__SENTRY_DEBUG_ID_UPLOAD_TEST__ = false;
+
+  await rollup.rollup({
+    input: { bundle1: path.resolve(__dirname, "input", "bundle.js") },
+    plugins: [
+      sentryRollupPlugin({
+        telemetry: false,
+        sourcemaps: {
+          disable: true,
+        },
+      }),
+    ],
+  });
+
+  expect(gbl.__SENTRY_DEBUG_ID_UPLOAD_TEST__).toBe(false);
+});
+
+test("should call upload plugin when sourcemaps are enabled", async () => {
+  const gbl = getGlobalWithDebugIdUploads();
+  gbl.__SENTRY_DEBUG_ID_UPLOAD_TEST__ = false;
+
+  await rollup.rollup({
+    input: { bundle1: path.resolve(__dirname, "input", "bundle.js") },
+    plugins: [
+      sentryRollupPlugin({
+        telemetry: false,
+      }),
+    ],
+  });
+
+  expect(gbl.__SENTRY_DEBUG_ID_UPLOAD_TEST__).toBe(true);
+});

packages/integration-tests/fixtures/disabled-sourcemaps-upload/input/bundle.js

@@ -0,0 +1,2 @@
+// eslint-disable-next-line no-console
+console.log("Beep!");

packages/integration-tests/package.json

@@ -47,4 +47,4 @@
   "volta": {
     "extends": "../../package.json"
   }
-}
+}

packages/rollup-plugin/src/index.ts

@@ -45,6 +45,12 @@ function rollupDebugIdUploadPlugin(
   logger: Logger,
   createDependencyOnBuildArtifacts: () => () => void
 ): UnpluginOptions {
+  // Only for testing purposes
+  if (process.env["NODE_ENV"] === "test") {
+    if ("__SENTRY_DEBUG_ID_UPLOAD_TEST__" in global) {
+      global.__SENTRY_DEBUG_ID_UPLOAD_TEST__ = true;
+    }
+  }
   return {
     name: "sentry-rollup-debug-id-upload-plugin",
     rollup: createRollupDebugIdUploadHooks(upload, logger, createDependencyOnBuildArtifacts),