test: More bundler versions (#725)

Author: timfish

.github/workflows/checks.yml

@@ -125,9 +125,11 @@ jobs:
             # "10.24.1",
             # vite uses optional chaining which isn't compatible with node 12
             # "12.22.12",
-            "14.21.1",
-            "16.18.1",
-            "18.12.1",
+            "14",
+            "16",
+            "18",
+            "20",
+            "22",
           ]
         os: [ubuntu-latest, windows-latest]
     runs-on: ${{ matrix.os }}

packages/integration-tests/fixtures/disabled-debug-id-injection/disabled-debug-id-injection.test.ts

@@ -6,10 +6,10 @@ import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 function checkBundle(bundlePath1: string, bundlePath2: string) {
   const process1Output = childProcess.execSync(`node ${bundlePath1}`, { encoding: "utf-8" });
-  expect(process1Output).toBe("undefined\n");
+  expect(process1Output).toMatch(/undefined/);
 
   const process2Output = childProcess.execSync(`node ${bundlePath2}`, { encoding: "utf-8" });
-  expect(process2Output).toBe("undefined\n");
+  expect(process2Output).toMatch(/undefined/);
 }
 
 describe("should not inject debug IDs when `sourcemaps.disable` is `true`", () => {

packages/integration-tests/package.json

@@ -39,8 +39,10 @@
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "rollup": "3.2.0",
+    "rollup4": "npm:rollup@^4",
     "ts-node": "^10.9.1",
     "vite": "3.0.0",
+    "vite6": "npm:vite@^6",
     "webpack4": "npm:webpack@^4",
     "webpack5": "npm:[email protected]"
   },

packages/integration-tests/utils/create-cjs-bundles.ts

@@ -1,6 +1,6 @@
-import * as vite from "vite";
+import * as vite3 from "vite";
 import * as path from "path";
-import * as rollup from "rollup";
+import * as rollup3 from "rollup";
 import { default as webpack4 } from "webpack4";
 import { webpack as webpack5 } from "webpack5";
 import * as esbuild from "esbuild";
@@ -10,17 +10,48 @@ import { sentryWebpackPlugin } from "@sentry/webpack-plugin";
 import { sentryEsbuildPlugin } from "@sentry/esbuild-plugin";
 import { sentryRollupPlugin } from "@sentry/rollup-plugin";
 
-// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-const nodejsMajorversion = process.version.split(".")[0]!.slice(1);
+const [NODE_MAJOR_VERSION] = process.version.split(".").map(Number) as [number];
+
+type Bundlers =
+  | "webpack4"
+  | "webpack5"
+  | "esbuild"
+  | "rollup"
+  | "rollup4"
+  | "vite"
+  | "vite6"
+  | string;
 
 export function createCjsBundles(
   entrypoints: { [name: string]: string },
   outFolder: string,
   sentryUnpluginOptions: Options,
-  plugins: string[] = []
+  plugins: Bundlers[] = []
 ): void {
   if (plugins.length === 0 || plugins.includes("vite")) {
-    void vite.build({
+    void vite3.build({
+      clearScreen: false,
+      build: {
+        sourcemap: true,
+        outDir: path.join(outFolder, "vite"),
+        rollupOptions: {
+          input: entrypoints,
+          output: {
+            format: "cjs",
+            entryFileNames: "[name].js",
+          },
+        },
+      },
+      plugins: [sentryVitePlugin(sentryUnpluginOptions)],
+    });
+  }
+
+  if (NODE_MAJOR_VERSION >= 18 && (plugins.length === 0 || plugins.includes("vite6"))) {
+    // We can't import this at the top of the file because they are not
+    // compatible with Node v14
+    // eslint-disable-next-line @typescript-eslint/no-var-requires
+    const vite6 = require("vite6") as typeof vite3;
+    void vite6.build({
       clearScreen: false,
       build: {
         sourcemap: true,
@@ -36,8 +67,29 @@ export function createCjsBundles(
       plugins: [sentryVitePlugin(sentryUnpluginOptions)],
     });
   }
+
   if (plugins.length === 0 || plugins.includes("rollup")) {
-    void rollup
+    void rollup3
+      .rollup({
+        input: entrypoints,
+        plugins: [sentryRollupPlugin(sentryUnpluginOptions)],
+      })
+      .then((bundle) =>
+        bundle.write({
+          sourcemap: true,
+          dir: path.join(outFolder, "rollup"),
+          format: "cjs",
+          exports: "named",
+        })
+      );
+  }
+
+  if (NODE_MAJOR_VERSION >= 18 && (plugins.length === 0 || plugins.includes("rollup4"))) {
+    // We can't import this at the top of the file because they are not
+    // compatible with Node v14
+    // eslint-disable-next-line @typescript-eslint/no-var-requires
+    const rollup4 = require("rollup4") as typeof rollup3;
+    void rollup4
       .rollup({
         input: entrypoints,
         plugins: [sentryRollupPlugin(sentryUnpluginOptions)],
@@ -65,7 +117,7 @@ export function createCjsBundles(
   }
 
   // Webpack 4 doesn't work on Node.js versions >= 18
-  if (parseInt(nodejsMajorversion) < 18 && (plugins.length === 0 || plugins.includes("webpack4"))) {
+  if (NODE_MAJOR_VERSION < 18 && (plugins.length === 0 || plugins.includes("webpack4"))) {
     webpack4(
       {
         devtool: "source-map",