`sentryVitePlugin()` should be typed as `PluginOption` provided by `vite`

[SimonSimCity]

Since sentryVitePlugin() is a vite-plugin, it should be typed as PluginOption, provided by vite package. Having it as any creates a violation of the eslint rule when registering it.

Since this rule is part of the "plugin:@typescript-eslint/recommended-type-checked" set, I expect quite some teams having this enabled.

I've tried forking this package and trying to set the type myself, but the setup was quite complicated, and some packages even seem to be sentry-internal.

[s1gr1d]

Hello and thanks for reaching out. Changing this type would be a breaking change we could only do in a major version. As we are using unplugin, the types are coming from there and users had issues with those typings in the past, so the return type was casted to any. But we can reconsider this for the next major.

[amitbeck]

As we are using unplugin, the types are coming from there and users had issues with those typings in the past, so the return type was casted to any.

@s1gr1d The simplest solution would've been casting first to unknown and then to the relevant type, in this case PluginOption:

// packages/vite-plugin/src/index.ts
import type { PluginOption } from 'vite';
// ...
export const sentryVitePlugin = sentryUnplugin.vite as unknown as (options?: Options) => PluginOption;

Using any is counter-productive.